From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Esben Haabendal <esben.haabendal@gmail.com>
Cc: linux-i2c@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Yuan Yao <yao.yuan@freescale.com>, Esben Haabendal <eha@deif.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Shawn Guo <shawnguo@kernel.org>,
kernel@pengutronix.de, NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v2 4/4] arm: dts: ls1021a: Enable I2C DMA support
Date: Tue, 24 Jul 2018 10:02:48 +0200 [thread overview]
Message-ID: <20180724080248.gncihyhiibzkvkzg@pengutronix.de> (raw)
In-Reply-To: <20180709094304.8814-5-esben.haabendal@gmail.com>
Hello,
expanding Cc a bit to include Shawn and the kernel teams of Pengutronix
and NXP.
On Mon, Jul 09, 2018 at 11:43:04AM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <eha@deif.com>
>
> Gives substantial performance improvement for transfers larger than 16
> bytes (DMA_THRESHOLD). Smaller transfers are unaffected.
>
> Signed-off-by: Esben Haabendal <eha@deif.com>
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index c55d479971cc..1e5640701c65 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -363,6 +363,8 @@
> interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "i2c";
> clocks = <&clockgen 4 1>;
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 39>, <&edma0 1 38>;
> status = "disabled";
> };
>
> @@ -374,6 +376,8 @@
> interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "i2c";
> clocks = <&clockgen 4 1>;
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 37>, <&edma0 1 36>;
> status = "disabled";
> };
>
> @@ -385,6 +389,8 @@
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "i2c";
> clocks = <&clockgen 4 1>;
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 35>, <&edma0 1 34>;
> status = "disabled";
> };
This is a bit orthogonal to the other changes in this series and needs
at least an ack from Shawn. Looks ok in my eyes.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2018-07-24 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180709094304.8814-1-esben.haabendal@gmail.com>
2018-07-09 9:43 ` [PATCH v2 1/4] i2c: imx: Fix reinit_completion() use Esben Haabendal
2018-07-23 18:08 ` Wolfram Sang
2018-07-09 9:43 ` [PATCH v2 2/4] i2c: imx: Fix race condition in dma read Esben Haabendal
2018-07-24 7:57 ` Uwe Kleine-König
2018-08-09 11:57 ` Esben Haabendal
2018-07-09 9:43 ` [PATCH v2 3/4] i2c: imx: Simplify stopped state tracking Esben Haabendal
2018-07-24 7:59 ` Uwe Kleine-König
2018-08-09 12:06 ` Esben Haabendal
2018-08-09 16:26 ` Uwe Kleine-König
2018-08-10 9:25 ` Esben Haabendal
2018-08-10 12:25 ` Uwe Kleine-König
2018-07-09 9:43 ` [PATCH v2 4/4] arm: dts: ls1021a: Enable I2C DMA support Esben Haabendal
2018-07-24 8:02 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724080248.gncihyhiibzkvkzg@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=eha@deif.com \
--cc=esben.haabendal@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).