From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB838ECDFB8 for ; Tue, 24 Jul 2018 08:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A118320856 for ; Tue, 24 Jul 2018 08:03:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A118320856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388561AbeGXJIK (ORCPT ); Tue, 24 Jul 2018 05:08:10 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:52937 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388427AbeGXJIK (ORCPT ); Tue, 24 Jul 2018 05:08:10 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhsHS-00005W-0Z; Tue, 24 Jul 2018 10:02:50 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1fhsHR-0003jP-0Z; Tue, 24 Jul 2018 10:02:49 +0200 Date: Tue, 24 Jul 2018 10:02:48 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Esben Haabendal Cc: linux-i2c@vger.kernel.org, Wolfram Sang , Rob Herring , Mark Rutland , Yuan Yao , Esben Haabendal , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo , kernel@pengutronix.de, NXP Linux Team Subject: Re: [PATCH v2 4/4] arm: dts: ls1021a: Enable I2C DMA support Message-ID: <20180724080248.gncihyhiibzkvkzg@pengutronix.de> References: <20180709094304.8814-1-esben.haabendal@gmail.com> <20180709094304.8814-5-esben.haabendal@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180709094304.8814-5-esben.haabendal@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, expanding Cc a bit to include Shawn and the kernel teams of Pengutronix and NXP. On Mon, Jul 09, 2018 at 11:43:04AM +0200, Esben Haabendal wrote: > From: Esben Haabendal > > Gives substantial performance improvement for transfers larger than 16 > bytes (DMA_THRESHOLD). Smaller transfers are unaffected. > > Signed-off-by: Esben Haabendal > --- > arch/arm/boot/dts/ls1021a.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > index c55d479971cc..1e5640701c65 100644 > --- a/arch/arm/boot/dts/ls1021a.dtsi > +++ b/arch/arm/boot/dts/ls1021a.dtsi > @@ -363,6 +363,8 @@ > interrupts = ; > clock-names = "i2c"; > clocks = <&clockgen 4 1>; > + dma-names = "tx", "rx"; > + dmas = <&edma0 1 39>, <&edma0 1 38>; > status = "disabled"; > }; > > @@ -374,6 +376,8 @@ > interrupts = ; > clock-names = "i2c"; > clocks = <&clockgen 4 1>; > + dma-names = "tx", "rx"; > + dmas = <&edma0 1 37>, <&edma0 1 36>; > status = "disabled"; > }; > > @@ -385,6 +389,8 @@ > interrupts = ; > clock-names = "i2c"; > clocks = <&clockgen 4 1>; > + dma-names = "tx", "rx"; > + dmas = <&edma0 1 35>, <&edma0 1 34>; > status = "disabled"; > }; This is a bit orthogonal to the other changes in this series and needs at least an ack from Shawn. Looks ok in my eyes. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |