linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <jiang.biao2@zte.com.cn>
To: <peterz@infradead.org>
Cc: <chen.lin130@zte.com.cn>, <mingo@redhat.com>,
	<linux-kernel@vger.kernel.org>, <zhong.weidong@zte.com.cn>,
	<tan.hu@zte.com.cn.cn>, <cheng.lin130@zte.com.cn>,
	<tan.hu@zte.com.cn>
Subject: Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus
Date: Tue, 24 Jul 2018 09:11:37 +0800 (CST)	[thread overview]
Message-ID: <201807240911372861670@zte.com.cn> (raw)
In-Reply-To: <20180723084031.GX2494@hirez.programming.kicks-ass.net>


[-- Attachment #1.1: Type: text/plain, Size: 1345 bytes --]

>
> On Mon, Jul 23, 2018 at 01:39:30PM +0800, Chen Lin wrote:
>> From: Chen Lin <cheng.lin130@zte.com.cn>
>>
>> NUMA balancing has not taken *isolcpus(isolated cpus)* into
>> consideration. It may migrate tasks onto isolated cpus and the
>> migrated tasks will never escape from the isolated cpus, which will
>> break the isolation provided by *isolcpus* boot parameter and
>> intrduce various problems.
>>
>> This patch ensure NUMA balancing not to balance tasks onto iaolated
>> cpus.
>
> I'm not sure what kernel you're patching, but cpu_isolated_map doesn't
> exist anymore. Also, if it steps on isolated CPUs, this is the wrong fix
> anyway. Load-balancing should be constrained to the current root domain.
Indeed, we used 4.14 version and made wrong assumption, sorry for that.
We will retest on latest mainline version, rework the patch and send another
version.

>> Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
>> Signed-off-by: Tan Hu <tan.hu@zte.com.cn>
>> Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn>
> 
>This SoB chain is invalid.
Mm, we don't quite understand what the *Signed-off-by* precisely means,
Does it only mean DCO(developer certificate of origin)?
As we understood, multiple SoBs could be used to indicate co-authors.
If SoB only means DCO, how can the patches reflect co-authors?

Thanks a lot.
Jiang,
Regards

  reply	other threads:[~2018-07-24  1:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23  5:39 [PATCH] sched/numa: do not balance tasks onto isolated cpus Chen Lin
2018-07-23  8:40 ` Peter Zijlstra
2018-07-24  1:11   ` jiang.biao2 [this message]
2018-07-24  9:06     ` Peter Zijlstra
2018-07-25  0:30       ` jiang.biao2
2018-07-25  8:35         ` Peter Zijlstra
2018-07-25  8:52           ` jiang.biao2
2018-07-23 20:06 ` kbuild test robot
2018-07-23 20:06 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201807240911372861670@zte.com.cn \
    --to=jiang.biao2@zte.com.cn \
    --cc=chen.lin130@zte.com.cn \
    --cc=cheng.lin130@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tan.hu@zte.com.cn \
    --cc=tan.hu@zte.com.cn.cn \
    --cc=zhong.weidong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).