LKML Archive on
 help / color / Atom feed
From: Arnd Bergmann <>
To: Andrew Morton <>,
	Eric Biggers <>,
	Al Viro <>,
	Greg Kroah-Hartman <>
Cc: Arnd Bergmann <>,
Subject: [PATCH] eventfs: include linux/errno.h in header
Date: Tue, 24 Jul 2018 13:07:13 +0200
Message-ID: <> (raw)

The new gasket staging driver ran into a randconfig build failure when
CONFIG_EVENTFD is disabled:

In file included from drivers/staging/gasket/gasket_interrupt.h:11,
                 from drivers/staging/gasket/gasket_interrupt.c:4:
include/linux/eventfd.h: In function 'eventfd_ctx_fdget':
include/linux/eventfd.h:51:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]

I can't see anything wrong with including eventfd.h before err.h,
so the easiest fix is to make it possible to do this by including the
file where it is needed.

Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")
Signed-off-by: Arnd Bergmann <>
 include/linux/eventfd.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h
index 7094718b653b..ffcc7724ca21 100644
--- a/include/linux/eventfd.h
+++ b/include/linux/eventfd.h
@@ -11,6 +11,7 @@
 #include <linux/fcntl.h>
 #include <linux/wait.h>
+#include <linux/err.h>
  * CAREFUL: Check include/uapi/asm-generic/fcntl.h when defining

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox