From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Aastha Gupta <aastha.gupta4104@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: rtl8188eu/rtl8723bs: fix character encoding
Date: Tue, 24 Jul 2018 13:55:32 +0200 [thread overview]
Message-ID: <20180724115532.GA18156@kroah.com> (raw)
In-Reply-To: <20180724115317.GA5928@kroah.com>
On Tue, Jul 24, 2018 at 01:53:17PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 24, 2018 at 01:13:28PM +0200, Arnd Bergmann wrote:
> > drivers/staging/rtl8188eu/include/odm.h uses an incorrect encoding
> > for the '...' character in two comments, which makes it one of the
> > few non-UTF-8 source files.
> >
> > This removes the odd characters and uses the same ASCII representation
> > that we have in the regular rtlwifi driver. The second instance
> > of drivers/staging/rtl8723bs/hal/odm.h is garbled in a different way,
> > so I change it to be the same as well even though it is already
> > plain ASCII.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
>
> git does not like this patch:
> error: cannot convert from Binary to UTF-8
> fatal: could not parse patch
> Let me see if I can force it by hand...
>
Had to remove the "Binary" marking on the email and then it worked.
Odd...
greg k-h
next prev parent reply other threads:[~2018-07-24 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 11:13 [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8 Arnd Bergmann
2018-07-24 11:13 ` [PATCH 2/4] s390: ebcdic: convert comments to UTF-8 Arnd Bergmann
2018-07-24 11:13 ` [PATCH 3/4] lib/fonts: convert comments to utf-8 Arnd Bergmann
2018-07-24 11:13 ` [PATCH 4/4] staging: rtl8188eu/rtl8723bs: fix character encoding Arnd Bergmann
2018-07-24 11:53 ` Greg Kroah-Hartman
2018-07-24 11:55 ` Greg Kroah-Hartman [this message]
2018-07-24 15:33 ` [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8 Simon Horman
2018-07-24 21:00 ` Andrew Morton
2018-07-24 21:02 ` Randy Dunlap
2018-07-25 0:13 ` Joe Perches
2018-07-25 0:55 ` Andrew Morton
2018-07-25 13:12 ` Arnd Bergmann
2018-07-25 15:33 ` Joe Perches
2018-07-24 21:04 ` Jonathan Cameron
2018-07-25 4:20 ` Michael Ellerman
2018-07-31 21:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724115532.GA18156@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aastha.gupta4104@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).