From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Akash Gajjar <gajjar04akash@gmail.com>
Cc: icenowy@aosc.xyz, Akash Gajjar <Akash_Gajjar@mentor.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: activate spi flash on pine64 LTS board
Date: Tue, 24 Jul 2018 14:51:51 +0200 [thread overview]
Message-ID: <20180724125151.plhn5g3x37ah62xu@flea> (raw)
In-Reply-To: <1532274409-9921-1-git-send-email-Akash_Gajjar@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]
Hi!
On Sun, Jul 22, 2018 at 09:16:49PM +0530, Akash Gajjar wrote:
> This board has a 128M SPI flash. add spi flash support in device tree.
>
> Tested on pine64 LTS.
>
> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
The author email should match the one in the SoB, and the prefix of
your commit title should be "arm64: dts: allwinner: ..."
> ---
> .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index abe179d..d54637d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -134,6 +134,29 @@
> regulator-name = "vcc-wifi";
> };
>
> +&spi0 {
> + status = "okay";
> +
> + m25p80@0 {
The node-name should be the device class, not the device model
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "w25q128";
According to the binding, this should have "jedec,spi-nor", and you
should put the vendor name before the model name as well.
> + reg = <0x0>;
> + linux,modalias = "m25p80", "w25q128";
This property isn
> + spi-max-frequency = <40000000>;
> +
> + uboot@0 {
> + label = "uboot";
> + reg = <0x0 0x100000>;
> + };
> +
> + rootfs@0 {
> + label = "rootfs";
> + reg = <0x100000 0x7F00000>;
> + };
This forces a partition scheme on users that might feel
differently. This should be removed.
maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-07-24 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 15:46 [PATCH] arm64: activate spi flash on pine64 LTS board Akash Gajjar
2018-07-24 12:51 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724125151.plhn5g3x37ah62xu@flea \
--to=maxime.ripard@bootlin.com \
--cc=Akash_Gajjar@mentor.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gajjar04akash@gmail.com \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).