From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71092ECDFB8 for ; Tue, 24 Jul 2018 15:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35C8020874 for ; Tue, 24 Jul 2018 15:14:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35C8020874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388466AbeGXQVf (ORCPT ); Tue, 24 Jul 2018 12:21:35 -0400 Received: from foss.arm.com ([217.140.101.70]:53588 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388306AbeGXQVe (ORCPT ); Tue, 24 Jul 2018 12:21:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9EB9A80D; Tue, 24 Jul 2018 08:14:37 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6F19B3F237; Tue, 24 Jul 2018 08:14:37 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 1C3651AE3B5E; Tue, 24 Jul 2018 16:14:37 +0100 (BST) Date: Tue, 24 Jul 2018 16:14:37 +0100 From: Will Deacon To: "Rafael J. Wysocki" Cc: Arnd Bergmann , AKASHI Takahiro , Ard Biesheuvel , Catalin Marinas , Tony Luck , Fenghua Yu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , "Rafael J. Wysocki" , Len Brown , Mark Rutland , Marc Zyngier , Linux ARM , Linux Kernel Mailing List , linux-ia64@vger.kernel.org, ACPI Devel Maling List Subject: Re: [PATCH] [SUBMITTED 20180724] arm64: fix ACPI dependencies Message-ID: <20180724151435.GB25412@arm.com> References: <20180724094957.1967541-1-arnd@arndb.de> <20180724102102.GI19324@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 12:23:48PM +0200, Rafael J. Wysocki wrote: > On Tue, Jul 24, 2018 at 12:21 PM, Will Deacon wrote: > > On Tue, Jul 24, 2018 at 11:54:25AM +0200, Rafael J. Wysocki wrote: > >> On Tue, Jul 24, 2018 at 11:48 AM, Arnd Bergmann wrote: > >> > Kconfig reports a warning on x86 builds after the ARM64 dependency > >> > was added. > >> > > >> > drivers/acpi/Kconfig:6:error: recursive dependency detected! > >> > drivers/acpi/Kconfig:6: symbol ACPI depends on EFI > >> > > >> > This rephrases the dependency to keep the ARM64 details out of the > >> > shared Kconfig file, so Kconfig no longer gets confused by it. > >> > > >> > For consistency, all three architectures that support ACPI now > >> > select ARCH_SUPPORTS_ACPI in exactly the configuration in which > >> > they allow it. We still need the 'default x86', as each one > >> > wants a different default: default-y on x86, default-n on arm64, > >> > and always-y on ia64. > >> > > >> > Fixes: 5bcd44083a08 ("drivers: acpi: add dependency of EFI for arm64") > >> > Signed-off-by: Arnd Bergmann > >> > --- > >> > v2: use 'select ARCH_SUPPORTS_ACPI' for all three. > >> > >> LGTM > >> > >> Reviewed-by: Rafael J. Wysocki > > > > Same here: > > > > Acked-by: Will Deacon > > > > Would it be ok if I take this via the arm64 tree, since that's where the > > warning was introduced? > > Yes, it would, from the ACPI side. Ok, I'll stick this into next tomorrow pending any objections from the x86 maintainers. Will