From: Minchan Kim <minchan@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Tino Lehnig <tino.lehnig@contabo.de>,
ngupta@vflare.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process...
Date: Wed, 25 Jul 2018 11:51:06 +0900 [thread overview]
Message-ID: <20180725025106.GA99093@rodete-desktop-imager.corp.google.com> (raw)
In-Reply-To: <20180725023532.GB16271@bombadil.infradead.org>
On Tue, Jul 24, 2018 at 07:35:32PM -0700, Matthew Wilcox wrote:
> On Wed, Jul 25, 2018 at 11:16:57AM +0900, Minchan Kim wrote:
> > On Tue, Jul 24, 2018 at 06:55:02PM -0700, Matthew Wilcox wrote:
> > > On Wed, Jul 25, 2018 at 10:32:50AM +0900, Minchan Kim wrote:
> > > > Hi Tino,
> > > >
> > > > On Tue, Jul 24, 2018 at 09:30:34AM +0200, Tino Lehnig wrote:
> > > > > Hi,
> > > > >
> > > > > The first build I used was from the master branch of the mainline kernel,
> > > > > somewhere between rc5 and rc6. I have just reproduced the bug with 4.17.9
> > > > > and 4.18-rc6. Kernel messages below.
> > > > >
> > > > > The bug does not appear on 4.14.57. I can test more versions if it helps.
> > > >
> > > > Could you try 4.15?
> > > >
> > > > I think it's a regression of struct page field reordring and it started from
> > > > v4.16.
> > > >
> > > > page->units for zsmalloc is used as offset of first object on the zspage,
> > > > However, below patch unified it with page->_refcount.
> > >
> > > No it didn't. It's in a union with _mapcount, which is where it was before
> > > my patches.
> > >
> > > It's entiely possible that my patches caused this, but the explanation
> > > you're offering is wrong.
> >
> > Before your patch, _mapcount and _refcount is separated space so we can use
> > _mapcount for page->units for non-mapped pages because units is unified with
> > _mapcount. However, with your patch, now units is unified with _refcount.
>
> No. That's completely untrue.
>
> union { /* This union is 4 bytes in size. */
> atomic_t _mapcount;
> unsigned int page_type;
> unsigned int active; /* SLAB */
> int units; /* SLOB */
> };
>
> atomic_t _refcount;
>
> There is NOTHING in a union with _refcount.
>
Confusing. Matthew, what am I missing?
Before:
counters consumes 8 bytes
units and _refcount consumes each 4 bytes so memory space is not overlapped.
union {
unsigned long counters;
struct {
union {
atomic_t _mapcount;
unsigned int active; /* SLAB */
struct { /* SLUB */
unsigned inuse:16;
unsigned objects:15;
unsigned frozen:1;
};
int units; /* SLOB */
};
/*
* Usage count, *USE WRAPPER FUNCTION* when manual
* accounting. See page_ref.h
*/
atomic_t _refcount;
};
};
After:
Now, units is overlapped with _refcount and _mapcount.
union {
unsigned long counters;
unsigned int active; /* SLAB */
struct { /* SLUB */
unsigned inuse:16;
unsigned objects:15;
unsigned frozen:1;
};
int units; /* SLOB */
struct { /* Page cache */
atomic_t _mapcount;
atomic_t _refcount;
};
};
next prev parent reply other threads:[~2018-07-25 2:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 12:29 Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process Tino Lehnig
2018-07-24 1:03 ` Minchan Kim
2018-07-24 2:53 ` Sergey Senozhatsky
2018-07-24 6:47 ` Minchan Kim
2018-07-24 7:30 ` Tino Lehnig
2018-07-25 1:32 ` Minchan Kim
2018-07-25 1:55 ` Matthew Wilcox
2018-07-25 2:16 ` Minchan Kim
2018-07-25 2:35 ` Matthew Wilcox
2018-07-25 2:51 ` Minchan Kim [this message]
2018-07-25 2:55 ` Matthew Wilcox
2018-07-25 3:02 ` Minchan Kim
2018-07-25 2:51 ` Matthew Wilcox
2018-07-25 4:07 ` Sergey Senozhatsky
2018-07-25 13:21 ` Minchan Kim
2018-07-25 15:12 ` Tino Lehnig
2018-07-26 2:03 ` Minchan Kim
2018-07-26 6:10 ` Tino Lehnig
2018-07-26 6:21 ` Minchan Kim
2018-07-26 6:34 ` Tino Lehnig
2018-07-26 10:00 ` Tino Lehnig
2018-07-26 10:30 ` Minchan Kim
2018-07-26 12:35 ` Tino Lehnig
2018-07-27 9:14 ` Minchan Kim
2018-07-27 11:00 ` Tino Lehnig
2018-07-27 12:05 ` Minchan Kim
2018-07-27 12:13 ` Tino Lehnig
2018-07-27 22:58 ` Minchan Kim
2018-07-30 6:09 ` Tino Lehnig
2018-08-02 5:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725025106.GA99093@rodete-desktop-imager.corp.google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tino.lehnig@contabo.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).