linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Artem Savkov <asavkov@redhat.com>, Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kprobes: fix trace_probe flags in enable_trace_kprobe
Date: Wed, 25 Jul 2018 10:05:41 -0400	[thread overview]
Message-ID: <20180725100541.36f27954@gandalf.local.home> (raw)
In-Reply-To: <20180725135632.zmjq7cuqc7eshpsh@treble>

On Wed, 25 Jul 2018 08:56:32 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Wed, Jul 25, 2018 at 12:28:26PM +0200, Artem Savkov wrote:
> > If enable_trace_kprobe fails to enable the probe in enable_k(ret)probe
> > it returns an error, but does not unset the tp flags it set previosly.  
> 
> "previously"

I tentatively added this to my queue. I updated the subject as:

 tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

But yeah, that needs to be fixed.

> 
> > @@ -424,6 +423,16 @@ enable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file)
> >  		else
> >  			ret = enable_kprobe(&tk->rp.kp);
> >  	}
> > +
> > +	if (ret) {
> > +		if (file) {
> > +			list_del(&link->list);  
> 
> Should this be list_del_rcu(), since it was added to the list with
> list_add_tail_rcu()?
> 

Good catch. Yes, that should be list_del_rcu().

Artem,

Can you send a v2 with the changes.

Thanks,

-- Steve

      reply	other threads:[~2018-07-25 14:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 10:28 [PATCH] kprobes: fix trace_probe flags in enable_trace_kprobe Artem Savkov
2018-07-25 13:21 ` Steven Rostedt
2018-07-25 15:35   ` Masami Hiramatsu
2018-07-25 13:56 ` Josh Poimboeuf
2018-07-25 14:05   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725100541.36f27954@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=asavkov@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).