From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Artem Savkov <asavkov@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure
Date: Wed, 25 Jul 2018 11:43:04 -0400 [thread overview]
Message-ID: <20180725114304.6a5207af@gandalf.local.home> (raw)
In-Reply-To: <20180725150226.5jdhtj4j7bdp4ddu@treble>
On Wed, 25 Jul 2018 10:35:57 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Wed, Jul 25, 2018 at 04:20:38PM +0200, Artem Savkov wrote:
> > If enable_trace_kprobe fails to enable the probe in enable_k(ret)probe
> > it returns an error, but does not unset the tp flags it set previously.
> > This results in a probe being considered enabled and failures like being
> > unable to remove the probe through kprobe_events file since probes_open()
> > expects every probe to be disabled.
> >
> > Signed-off-by: Artem Savkov <asavkov@redhat.com>
>
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
Thanks Josh!
Queued up and currently being tested.
-- Steve
next prev parent reply other threads:[~2018-07-25 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 14:20 [PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure Artem Savkov
2018-07-25 14:30 ` Steven Rostedt
2018-07-25 15:35 ` Josh Poimboeuf
2018-07-25 15:43 ` Steven Rostedt [this message]
2018-07-25 15:41 ` Masami Hiramatsu
2018-07-25 15:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725114304.6a5207af@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=asavkov@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).