From: Andrew Morton <akpm@linux-foundation.org>
To: "zhaowuyun@wingtech.com" <zhaowuyun@wingtech.com>
Cc: mgorman <mgorman@techsingularity.net>,
minchan <minchan@kernel.org>, vinmenon <vinmenon@codeaurora.org>,
mhocko <mhocko@suse.com>, hannes <hannes@cmpxchg.org>,
"hillf.zj" <hillf.zj@alibaba-inc.com>,
linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] [PATCH] mm: disable preemption before swapcache_free
Date: Wed, 25 Jul 2018 14:16:43 -0700 [thread overview]
Message-ID: <20180725141643.6d9ba86a9698bc2580836618@linux-foundation.org> (raw)
In-Reply-To: <2018072514375722198958@wingtech.com>
On Wed, 25 Jul 2018 14:37:58 +0800 "zhaowuyun@wingtech.com" <zhaowuyun@wingtech.com> wrote:
> From: zhaowuyun <zhaowuyun@wingtech.com>
>
> issue is that there are two processes A and B, A is kworker/u16:8
> normal priority, B is AudioTrack, RT priority, they are on the
> same CPU 3.
>
> The task A preempted by task B in the moment
> after __delete_from_swap_cache(page) and before swapcache_free(swap).
>
> The task B does __read_swap_cache_async in the do {} while loop, it
> will never find the page from swapper_space because the page is removed
> by the task A, and it will never sucessfully in swapcache_prepare because
> the entry is EEXIST.
>
> The task B then stuck in the loop infinitely because it is a RT task,
> no one can preempt it.
>
> so need to disable preemption until the swapcache_free executed.
Yes, right, sorry, I must have merged cbab0e4eec299 in my sleep.
cond_resched() is a no-op in the presence of realtime policy threads
and using to attempt to yield to a different thread it in this fashion
is broken.
Disabling preemption on the other side of the race should fix things,
but it's using a bandaid to plug the leakage from the earlier bandaid.
The proper way to coordinate threads is to use a sleeping lock, such
as a mutex, or some other wait/wakeup mechanism.
And once that's done, we can hopefully eliminate the do loop from
__read_swap_cache_async(). That also services ENOMEM from
radix_tree_insert(), but __add_to_swap_cache() appears to handle that
OK and we shouldn't just loop around retrying the insert and the
radix_tree_preload() should ensure that radix_tree_insert() never fails
anyway. Unless we're calling __read_swap_cache_async() with screwy
gfp_flags from somewhere.
next prev parent reply other threads:[~2018-07-25 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2018072514375722198958@wingtech.com>
2018-07-25 7:40 ` [PATCH] [PATCH] mm: disable preemption before swapcache_free Michal Hocko
[not found] ` <2018072515575576668668@wingtech.com>
2018-07-25 8:21 ` Michal Hocko
2018-07-25 10:32 ` Michal Hocko
[not found] ` <2018072517530727482074@wingtech.com>
2018-07-25 10:34 ` Michal Hocko
2018-07-25 21:16 ` Andrew Morton [this message]
[not found] ` <2018072610214038358990@wingtech.com>
2018-07-26 6:06 ` Michal Hocko
[not found] ` <20180726150323057627100@wingtech.com>
2018-07-26 7:44 ` Michal Hocko
2018-07-26 22:11 ` Andrew Morton
[not found] ` <20180727140749669129112@wingtech.com>
2018-08-04 23:07 ` Hugh Dickins
[not found] ` <20180807101540612373235@wingtech.com>
2018-08-07 3:23 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725141643.6d9ba86a9698bc2580836618@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=vinmenon@codeaurora.org \
--cc=zhaowuyun@wingtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).