From: Rob Herring <robh@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Icenowy Zheng <icenowy@aosc.io>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH v3 6/9] dt-bindings: phy: add binding for Allwinner USB3 PHY
Date: Wed, 25 Jul 2018 09:31:26 -0600 [thread overview]
Message-ID: <20180725153126.GA8350@rob-hp-laptop> (raw)
In-Reply-To: <CAGb2v65m6AEW=DO-cqLMyjfnaiZudm38hXufJL6LXdOrJqir_g@mail.gmail.com>
On Sun, Jul 22, 2018 at 02:10:33PM +0800, Chen-Yu Tsai wrote:
> On Sun, Jul 22, 2018 at 1:57 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> > The new Allwinner H6 SoC contains a USB3 PHY that is wired to the
> > external USB3 pins of the SoC.
> >
> > Add a device tree binding for the PHY.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> > Changes in v3:
> > - Added Chen-Yu's Review tag.
> >
> > Rob,
> > Although you mentioned that the supply is for the port, not the phy;
> > currently in USB situation "powering on the PHY" also indicates
> > "powering on the port" and nearly all usages of phy-supply is for Vbus.
> >
> > Maybe we should change the overall phy-supply to satisfy this.
>
> Or maybe change it to vbus-supply, like we have for phy-sun4i-usb,
> until USB port power sequencing is added. (I remember there were
> patches for this. What happened?)
Once it is in the binding, we are stuck with it.
Connector bindings have landed. We should add vbus-supply to that. You
don't have to have a property in the node associated with a driver. The
phy driver can walk the tree and get the Vbus supply.
UniPhier has the same issue.
Rob
next prev parent reply other threads:[~2018-07-25 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 5:57 [PATCH v3 0/9] Allwinner H6 USB support Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 1/9] phy: sun4i-usb: add support for missing USB PHY index Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 2/9] phy: sun4i-usb: add support for H6 USB2 PHY Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 3/9] arm64: allwinner: dts: h6: add USB2-related device nodes Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 4/9] arm64: allwinner: dts: h6: add USB Vbus regulator Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 5/9] arm64: allwinner: dts: h6: enable USB2 on Pine H64 Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 6/9] dt-bindings: phy: add binding for Allwinner USB3 PHY Icenowy Zheng
2018-07-22 6:10 ` [linux-sunxi] " Chen-Yu Tsai
2018-07-25 15:31 ` Rob Herring [this message]
2018-07-25 15:38 ` Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 7/9] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 8/9] arm64: allwinner: dts: h6: add USB3 device nodes Icenowy Zheng
2018-07-22 5:57 ` [PATCH v3 9/9] arm64: allwinner: dts: h6: enable USB3 port on Pine H64 Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725153126.GA8350@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).