From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Emmanuel Vadot <manu@bidouilliste.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, Emmanuel Vadot <manu@freebsd.org>,
wens@csie.org, robh+dt@kernel.org,
srinivas.kandagatla@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
Date: Thu, 26 Jul 2018 13:54:09 +0200 [thread overview]
Message-ID: <20180726115409.7hqtvx4rdqcqdjrq@flea> (raw)
In-Reply-To: <20180724165501.d8f01bf20c7cc43e7ed7fc62@bidouilliste.com>
[-- Attachment #1: Type: text/plain, Size: 2110 bytes --]
On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> On Tue, 24 Jul 2018 16:42:18 +0200
> Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >
> > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > > The SID controller on H5 look the same as the one present in the A64.
> > > > > But in case we find some difference one day at a compatible string
> > > > > of it's own and a fallback to the A64 one.
> > > > >
> > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > ---
> > > > > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > > > 1 file changed, 5 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > index 62d646baac3c..28183bf77164 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > @@ -129,3 +129,8 @@
> > > > > <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > > > compatible = "allwinner,sun50i-h5-pinctrl";
> > > > > };
> > > > > +
> > > > > +&sid {
> > > > > + compatible = "allwinner,sun50i-h5-sid",
> > > > > + "allwinner,sun50i-a64-sid";
> > > > > +};
> > > >
> > > > This is still a bit pointless, please remove the common node.
> > >
> > > You mean directly declare sid controller in the SoC dtsi and not
> > > have a common node in sunxi-h3-h5.dtsi ?
> >
> > Yep
>
> The reason I've put it in the common file is because I'll send patches
> for the nvmem-cells needed for thermal, and those are common between
> the two. Other nvmem-cells are also common (like the chipid and
> probably other).
Then we'll see what we can have in common and what not when we'll have
something in common?
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-07-26 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 10:15 [PATCH v2 1/5] arm64: dts: allwinner: a64: Add SID node Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 2/5] ARM: dts: sunxi: h3/h5: " Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 3/5] ARM: dts: sun8i: h3: Add SID compatible string Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 4/5] nvmem: sunxi-sid: add support for H5's SID controller Emmanuel Vadot
2018-07-24 13:00 ` Maxime Ripard
2018-07-24 10:15 ` [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5 Emmanuel Vadot
2018-07-24 13:00 ` Maxime Ripard
2018-07-24 13:34 ` Emmanuel Vadot
2018-07-24 14:42 ` Maxime Ripard
2018-07-24 14:55 ` Emmanuel Vadot
2018-07-26 11:54 ` Maxime Ripard [this message]
2018-07-27 10:56 ` Emmanuel Vadot
2018-07-27 11:34 ` Emmanuel Vadot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726115409.7hqtvx4rdqcqdjrq@flea \
--to=maxime.ripard@bootlin.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manu@bidouilliste.com \
--cc=manu@freebsd.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).