linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Artem Savkov <asavkov@redhat.com>
Subject: Re: [PATCH] tracing/kprobes: Simplify the logic of enable_trace_kprobe()
Date: Thu, 26 Jul 2018 14:25:20 -0400	[thread overview]
Message-ID: <20180726142520.1b5f7c25@gandalf.local.home> (raw)
In-Reply-To: <20180726164352.tctldcryo4fs3nap@treble>

On Thu, 26 Jul 2018 11:43:52 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Thu, Jul 26, 2018 at 12:11:52PM -0400, Steven Rostedt wrote:
> > 
> > [ Note this is applied on top of the other patch to quiet gcc ]
> > 
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> > 
> > The function enable_trace_kprobe() performs slightly differently if the file
> > parameter is passed in as NULL on non-NULL. Instead of checking file twice,
> > move the code between the two tests into a static inline helper function to
> > make the code easier to follow.
> > 
> > Link: http://lkml.kernel.org/r/20180725224728.7b1d5db2@vmware.local.home
> > 
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>  
> 
> The enable_probe() name is a bit confusing, since it's not clear what
> the difference is between enable_probe() and enable_trace_kprobe()
> without looking at the code.

Yeah, I didn't like that name either.

> 
> Maybe call it __enable_trace_kprobe()?

Hmm, that may work.

> 
> Otherwise it's a definite improvement.
> 
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
> 

Thanks,

-- Steve


  reply	other threads:[~2018-07-26 18:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 16:11 [PATCH] tracing/kprobes: Simplify the logic of enable_trace_kprobe() Steven Rostedt
2018-07-26 16:43 ` Josh Poimboeuf
2018-07-26 18:25   ` Steven Rostedt [this message]
2018-07-27 12:52   ` Masami Hiramatsu
2018-07-27 13:38     ` [PATCH v2] " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180726142520.1b5f7c25@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=asavkov@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).