linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: "Alastair D'Silva" <alastair@d-silva.org>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Cyril Bur <cyrilbur@gmail.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Michael Neuling <mikey@neuling.org>,
	Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Simon Guo <wei.guo.simon@gmail.com>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	"Tobin C . Harding" <me@tobin.cc>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v2 05/10] powerpc/traps: Print VMA for unhandled signals
Date: Fri, 27 Jul 2018 11:58:06 -0300	[thread overview]
Message-ID: <20180727145811.12334-6-muriloo@linux.ibm.com> (raw)
In-Reply-To: <20180727145811.12334-1-muriloo@linux.ibm.com>

This adds VMA address in the message printed for unhandled signals,
similarly to what other architectures, like x86, print.

Before this patch, a page fault looked like:

    pandafault[61470]: unhandled signal 11 at 00000000100007d0 nip 000000001000061c lr 00007fff8d185100 code 2

After this patch, a page fault looks like:

    pandafault[6303]: unhandled signal 11 at 00000000100007d0 nip 000000001000061c lr 00007fff93c55100 code 2 in pandafault[10000000+10000]

Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
---
 arch/powerpc/kernel/traps.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 047d980ac776..e6c43ef9fb50 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -315,9 +315,13 @@ static void show_signal_msg(int signr, struct pt_regs *regs, int code,
 		return;
 
 	pr_info("%s[%d]: unhandled signal %d at "REG_FMT \
-		" nip "REG_FMT" lr "REG_FMT" code %x\n",
+		" nip "REG_FMT" lr "REG_FMT" code %x",
 		current->comm, current->pid, signr, addr,
 		regs->nip, regs->link, code);
+
+	print_vma_addr(KERN_CONT " in ", regs->nip);
+
+	pr_cont("\n");
 }
 
 void _exception_pkey(int signr, struct pt_regs *regs, int code,
-- 
2.17.1


  parent reply	other threads:[~2018-07-27 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 14:58 [PATCH v2 00/10] powerpc: Modernize unhandled signals message Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 01/10] powerpc/traps: Print unhandled signals in a separate function Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 02/10] powerpc/traps: Return early in show_signal_msg() Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 03/10] powerpc/reg: Add REG_FMT definition Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 04/10] powerpc/traps: Use REG_FMT in show_signal_msg() Murilo Opsfelder Araujo
2018-07-27 16:40   ` LEROY Christophe
2018-07-27 17:18     ` Joe Perches
2018-07-30 15:28     ` Murilo Opsfelder Araujo
2018-07-30 16:30       ` LEROY Christophe
2018-07-30 23:17         ` Murilo Opsfelder Araujo
2018-07-31  9:32           ` Michael Ellerman
2018-07-31  9:52             ` Alastair D'Silva
2018-07-27 14:58 ` Murilo Opsfelder Araujo [this message]
2018-07-27 14:58 ` [PATCH v2 06/10] powerpc/traps: Print signal name for unhandled signals Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 07/10] powerpc: Do not call __kernel_text_address() in show_instructions() Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 08/10] powerpc: Add stacktrace.h header Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 09/10] powerpc/traps: Show instructions on exceptions Murilo Opsfelder Araujo
2018-07-27 14:58 ` [PATCH v2 10/10] powerpc/traps: Add line prefix in show_instructions() Murilo Opsfelder Araujo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727145811.12334-6-muriloo@linux.ibm.com \
    --to=muriloo@linux.ibm.com \
    --cc=alastair@d-silva.org \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bsingharora@gmail.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=cyrilbur@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=me@tobin.cc \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=wei.guo.simon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).