From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0251C43142 for ; Mon, 30 Jul 2018 20:01:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 534A620857 for ; Mon, 30 Jul 2018 20:01:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 534A620857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731864AbeG3Vhq (ORCPT ); Mon, 30 Jul 2018 17:37:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36572 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729315AbeG3Vhq (ORCPT ); Mon, 30 Jul 2018 17:37:46 -0400 Received: from localhost (71-36-117-41.ptld.qwest.net [71.36.117.41]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A7B9913F6E186; Mon, 30 Jul 2018 13:01:10 -0700 (PDT) Date: Mon, 30 Jul 2018 13:01:10 -0700 (PDT) Message-Id: <20180730.130110.34198079056845850.davem@davemloft.net> To: thomas.petazzoni@bootlin.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, marc.zyngier@arm.com, hannah@marvell.com Subject: Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used From: David Miller In-Reply-To: <20180724115305.11289-1-thomas.petazzoni@bootlin.com> References: <20180724115305.11289-1-thomas.petazzoni@bootlin.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 30 Jul 2018 13:01:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Petazzoni Date: Tue, 24 Jul 2018 13:53:04 +0200 > The definitions in arch/sparc/include/asm/msi.h are only used in > arch/sparc/mm/srmmu.c, so it makes sense to have them in the C file > directly. > > In addition, having a custom arch/sparc/include/asm/msi.h prevents > from using the asm-generic version of this header, which is necessary > to be able to include when CONFIG_GENERIC_MSI_IRQ_DOMAIN > is enabled. > > Signed-off-by: Thomas Petazzoni Applied.