From: Michal Hocko <mhocko@kernel.org>
To: Jane Chu <jane.chu@oracle.com>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
jack@suse.cz, jglisse@redhat.com, mike.kravetz@oracle.com,
dave@stgolabs.net, linux-mm@kvack.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipc/shm.c add ->pagesize function to shm_vm_ops
Date: Mon, 30 Jul 2018 10:58:51 +0200 [thread overview]
Message-ID: <20180730085851.GB24267@dhcp22.suse.cz> (raw)
In-Reply-To: <20180727211727.5020-1-jane.chu@oracle.com>
On Fri 27-07-18 15:17:27, Jane Chu wrote:
> Commit 05ea88608d4e13 (mm, hugetlbfs: introduce ->pagesize() to
> vm_operations_struct) adds a new ->pagesize() function to
> hugetlb_vm_ops, intended to cover all hugetlbfs backed files.
>
> With System V shared memory model, if "huge page" is specified,
> the "shared memory" is backed by hugetlbfs files, but the mappings
> initiated via shmget/shmat have their original vm_ops overwritten
> with shm_vm_ops, so we need to add a ->pagesize function to shm_vm_ops.
> Otherwise, vma_kernel_pagesize() returns PAGE_SIZE given a hugetlbfs
> backed vma, result in below BUG:
>
> fs/hugetlbfs/inode.c
> 443 if (unlikely(page_mapped(page))) {
> 444 BUG_ON(truncate_op);
>
> [ 242.268342] hugetlbfs: oracle (4592): Using mlock ulimits for SHM_HUGETLB is deprecated
> [ 282.653208] ------------[ cut here ]------------
> [ 282.708447] kernel BUG at fs/hugetlbfs/inode.c:444!
> [ 282.818957] Modules linked in: nfsv3 rpcsec_gss_krb5 nfsv4 ...
> [ 284.025873] CPU: 35 PID: 5583 Comm: oracle_5583_sbt Not tainted 4.14.35-1829.el7uek.x86_64 #2
> [ 284.246609] task: ffff9bf0507aaf80 task.stack: ffffa9e625628000
> [ 284.317455] RIP: 0010:remove_inode_hugepages+0x3db/0x3e2
> ....
> [ 285.292389] Call Trace:
> [ 285.321630] hugetlbfs_evict_inode+0x1e/0x3e
> [ 285.372707] evict+0xdb/0x1af
> [ 285.408185] iput+0x1a2/0x1f7
> [ 285.443661] dentry_unlink_inode+0xc6/0xf0
> [ 285.492661] __dentry_kill+0xd8/0x18d
> [ 285.536459] dput+0x1b5/0x1ed
> [ 285.571939] __fput+0x18b/0x216
> [ 285.609495] ____fput+0xe/0x10
> [ 285.646030] task_work_run+0x90/0xa7
> [ 285.688788] exit_to_usermode_loop+0xdd/0x116
> [ 285.740905] do_syscall_64+0x187/0x1ae
> [ 285.785740] entry_SYSCALL_64_after_hwframe+0x150/0x0
>
> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
> Signed-off-by: Jane Chu <jane.chu@oracle.com>
Acked-by: Michal Hocko <mhocko@suse.com>
with Cc: stable and Fixes: tag as suggested by Mike.
I also agree with Matthew that the comment should be associated with
hugetlb_vm_ops/shm_vm_ops.
Thanks!
> ---
> include/linux/mm.h | 7 +++++++
> ipc/shm.c | 12 ++++++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index a0fbb9ffe380..0c759379f2d9 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -387,6 +387,13 @@ enum page_entry_size {
> * These are the virtual MM functions - opening of an area, closing and
> * unmapping it (needed to keep files on disk up-to-date etc), pointer
> * to the functions called when a no-page or a wp-page exception occurs.
> + *
> + * Note, when a new function is introduced to vm_operations_struct and
> + * added to hugetlb_vm_ops, please consider adding the function to
> + * shm_vm_ops. This is because under System V memory model, though
> + * mappings created via shmget/shmat with "huge page" specified are
> + * backed by hugetlbfs files, their original vm_ops are overwritten with
> + * shm_vm_ops.
> */
> struct vm_operations_struct {
> void (*open)(struct vm_area_struct * area);
> diff --git a/ipc/shm.c b/ipc/shm.c
> index 051a3e1fb8df..fefa00d310fb 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -427,6 +427,17 @@ static int shm_split(struct vm_area_struct *vma, unsigned long addr)
> return 0;
> }
>
> +static unsigned long shm_pagesize(struct vm_area_struct *vma)
> +{
> + struct file *file = vma->vm_file;
> + struct shm_file_data *sfd = shm_file_data(file);
> +
> + if (sfd->vm_ops->pagesize)
> + return sfd->vm_ops->pagesize(vma);
> +
> + return PAGE_SIZE;
> +}
> +
> #ifdef CONFIG_NUMA
> static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
> {
> @@ -554,6 +565,7 @@ static const struct vm_operations_struct shm_vm_ops = {
> .close = shm_close, /* callback for when the vm-area is released */
> .fault = shm_fault,
> .split = shm_split,
> + .pagesize = shm_pagesize,
> #if defined(CONFIG_NUMA)
> .set_policy = shm_set_policy,
> .get_policy = shm_get_policy,
> --
> 2.15.GIT
>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-30 8:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 21:17 [PATCH] ipc/shm.c add ->pagesize function to shm_vm_ops Jane Chu
2018-07-27 21:43 ` Mike Kravetz
2018-07-27 21:50 ` Andrew Morton
2018-07-28 0:40 ` Jane Chu
2018-07-28 19:02 ` Matthew Wilcox
2018-07-31 3:06 ` Jane Chu
2018-07-30 8:58 ` Michal Hocko [this message]
2018-07-31 3:07 ` Jane Chu
2018-07-30 16:44 ` Davidlohr Bueso
2018-07-31 3:08 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730085851.GB24267@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=jack@suse.cz \
--cc=jane.chu@oracle.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).