linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Akshu Agrawal <Akshu.Agrawal@amd.com>,
	"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
	MANAGEM..."  <alsa-devel@alsa-project.org>,
	Alexander.Deucher@amd.com, djkurtz@chromium.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-pcm: Use delay set in pointer function
Date: Mon, 30 Jul 2018 16:50:30 +0100	[thread overview]
Message-ID: <20180730155030.GP5789@sirena.org.uk> (raw)
In-Reply-To: <s5hy3dsviwq.wl-tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

On Mon, Jul 30, 2018 at 05:32:21PM +0200, Takashi Iwai wrote:

> That said, if delay callback of CPU dai provides the additional delay,
> the patch does correct thing.  OTOH, if CPU dai provides the base
> delay instead, we need to clarify that it's rather a must; the delay
> calculation in pointer callback becomes bogus in this scenario.

Part of the theory here is that every component might have a delay
independently of the rest and we need to add them all together to figure
out what the system as a whole will see.  Personally I'd rather just
have everything use a callack consistently to avoid confusion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-07-30 15:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 10:13 [PATCH] ASoC: soc-pcm: Use delay set in pointer function Akshu Agrawal
2018-07-27 15:09 ` [alsa-devel] " Pierre-Louis Bossart
2018-07-28  4:28   ` Agrawal, Akshu
2018-07-30 15:15     ` Pierre-Louis Bossart
2018-07-30 15:32       ` Takashi Iwai
2018-07-30 15:50         ` Mark Brown [this message]
2018-07-31  1:25           ` Agrawal, Akshu
2018-07-31  5:30             ` Takashi Iwai
2018-07-31  9:06               ` Agrawal, Akshu
2018-07-31  9:25                 ` Takashi Iwai
2018-07-31 10:19                   ` Mark Brown
2018-07-31 10:32                     ` Takashi Iwai
2018-07-31 13:12                       ` Mark Brown
2018-07-31 13:29                         ` Takashi Iwai
2018-07-31 13:51                           ` Mark Brown
2018-07-31 13:56                             ` Takashi Iwai
2018-07-31 14:40                               ` Mark Brown
2018-08-01  4:01                                 ` Agrawal, Akshu
2018-07-31 10:03               ` Mark Brown
2018-07-30 10:54 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730155030.GP5789@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Akshu.Agrawal@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=djkurtz@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).