From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: sd@queasysnail.net, eric.dumazet@gmail.com,
syzbot+41f9c04b50ef70c66947@syzkaller.appspotmail.com,
christian.brauner@ubuntu.com, dsahern@gmail.com, fw@strlen.de,
jbenc@redhat.com, ktkhai@virtuozzo.com,
linux-kernel@vger.kernel.org, lucien.xin@gmail.com,
netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: KASAN: use-after-free Read in rtnetlink_put_metrics
Date: Wed, 01 Aug 2018 11:46:36 -0700 (PDT) [thread overview]
Message-ID: <20180801.114636.279269263935333136.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpURKOMAaPfs9v7FzhqqQPzj71sQD2LS0eU8cuqTML-YoA@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 31 Jul 2018 16:03:13 -0700
> Looks like this commit is completely unnecessary,
> fib6_drop_pcpu_from() calls fib6_info_release()
> which calls fib6_info_destroy_rcu(), so this metrics
> will be released twice...
And even if there was a leak here, it's illegal to free this
metrics memory synchronously since it is RCU protected.
That's why it normally goes through fib6_info_destroy_rcu().
Sabrina, I'm going to revert your changes unless I see some
progress here by the end of today.
next prev parent reply other threads:[~2018-08-01 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 12:31 KASAN: use-after-free Read in rtnetlink_put_metrics syzbot
2018-07-31 12:41 ` Eric Dumazet
2018-07-31 13:40 ` Sabrina Dubroca
2018-07-31 21:53 ` David Miller
2018-07-31 23:03 ` Cong Wang
2018-08-01 8:15 ` Sabrina Dubroca
2018-08-01 8:28 ` David Ahern
2018-08-02 5:23 ` Cong Wang
2018-08-01 18:46 ` David Miller [this message]
2018-08-01 19:26 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801.114636.279269263935333136.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christian.brauner@ubuntu.com \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=jbenc@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=syzbot+41f9c04b50ef70c66947@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).