From: Richard Cochran <richardcochran@gmail.com>
To: "Y.b. Lu" <yangbo.lu@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for initialization
Date: Tue, 31 Jul 2018 23:15:15 -0700 [thread overview]
Message-ID: <20180801061515.krn52iaq2kqdi3wo@localhost> (raw)
In-Reply-To: <DB6PR0401MB253643010802739AD55820F3F82D0@DB6PR0401MB2536.eurprd04.prod.outlook.com>
On Wed, Aug 01, 2018 at 04:36:40AM +0000, Y.b. Lu wrote:
> Could I add a function to calculate a set of default register values
> to initialize ptp timer when dts method failed to get required
> properties in driver?
Yes, it would be ideal if the driver can pick correct values
automatically.
However, the frequency on the FIPER outputs can't be configured
automatically, and we don't have an API for the user to choose this.
> I think this will be useful. The ptp timer on new platforms (you may
> see two dts patches in this patchset. Many platforms will be
> affected.) will work without these dts properties. If user want
> specific setting, they can set dts properties.
Sure.
Thanks,
Richard
next prev parent reply other threads:[~2018-08-01 6:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 10:01 [PATCH 1/3] arm64: dts: fsl: add clocks property for fman ptp timer node Yangbo Lu
2018-07-30 10:01 ` [PATCH 2/3] powerpc/mpc85xx: " Yangbo Lu
2018-07-30 10:01 ` [PATCH 3/3] ptp_qoriq: convert to use module parameters for initialization Yangbo Lu
2018-07-30 14:30 ` Richard Cochran
2018-08-01 4:36 ` Y.b. Lu
2018-08-01 6:15 ` Richard Cochran [this message]
2018-08-01 10:10 ` Y.b. Lu
2018-07-30 16:25 ` David Miller
2018-08-01 4:38 ` Y.b. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801061515.krn52iaq2kqdi3wo@localhost \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).