From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Erica Bugden <erica.bugden@linutronix.de>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
anna-maria@linutronix.de, bigeasy@linutronix.de
Subject: Re: [PATCH] ftrace: Add missing check for existing hwlat thread
Date: Wed, 1 Aug 2018 16:03:20 -0400 [thread overview]
Message-ID: <20180801160320.3a4c63f7@gandalf.local.home> (raw)
In-Reply-To: <alpine.DEB.2.21.1808012151360.1835@nanos.tec.linutronix.de>
On Wed, 1 Aug 2018 21:59:38 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:
> > This looks like it is treating the symptom and not the disease.
>
> My bad. We looked at the other instances of tracers and they all have
> protection against this kind of call sequence ...
Probably because they were all fixing the symptom ;-)
I'm going to keep Erica's patch and add a WARN_ON() to it just in case.
But can you still check if the patch I gave fixes it too?
-- Steve
next prev parent reply other threads:[~2018-08-01 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 10:45 [PATCH] ftrace: Add missing check for existing hwlat thread Erica Bugden
2018-08-01 19:40 ` Steven Rostedt
2018-08-01 19:59 ` Thomas Gleixner
2018-08-01 20:03 ` Steven Rostedt [this message]
2018-08-01 20:07 ` Thomas Gleixner
2018-08-03 8:46 ` Erica Bugden
2018-08-03 13:37 ` Steven Rostedt
2018-08-03 14:57 ` Erica Bugden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801160320.3a4c63f7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=erica.bugden@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).