From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68EAC28CF6 for ; Wed, 1 Aug 2018 16:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45898208A3 for ; Wed, 1 Aug 2018 16:39:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45898208A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403854AbeHAS0Z (ORCPT ); Wed, 1 Aug 2018 14:26:25 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:45770 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389691AbeHAS0Z (ORCPT ); Wed, 1 Aug 2018 14:26:25 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fkuA7-0007zX-Mt; Wed, 01 Aug 2018 16:39:47 +0000 From: Colin King To: Ariel Elior , everest-linux-l2@cavium.com, "David S . Miller" , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] qede: fix null pointer dereference on skb on allocation failure Date: Wed, 1 Aug 2018 17:39:47 +0100 Message-Id: <20180801163947.22743-1-colin.king@canonical.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King If skb fails to be allocated with the call to build_skb then a null pointer dereference will occur on the call to skb_reserve. Fix this by checking for a null skb and returning NULL. Detected by CoverityScan, CID#1469485 ("Dereference null return value") Fixes: 8a8633978b84 ("qede: Add build_skb() support.") Signed-off-by: Colin Ian King --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c b/drivers/net/ethernet/qlogic/qede/qede_fp.c index 6c702399b801..4b912ff5c0f3 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c @@ -730,6 +730,8 @@ qede_build_skb(struct qede_rx_queue *rxq, buf = page_address(bd->data) + bd->page_offset; skb = build_skb(buf, rxq->rx_buf_seg_size); + if (!skb) + return NULL; skb_reserve(skb, pad); skb_put(skb, len); -- 2.17.1