From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B596C28CF6 for ; Wed, 1 Aug 2018 18:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC4B020844 for ; Wed, 1 Aug 2018 18:58:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC4B020844 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387595AbeHAUpk (ORCPT ); Wed, 1 Aug 2018 16:45:40 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35060 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387527AbeHAUpk (ORCPT ); Wed, 1 Aug 2018 16:45:40 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 32C5D806CA; Wed, 1 Aug 2018 20:58:28 +0200 (CEST) Date: Wed, 1 Aug 2018 20:58:24 +0200 From: Pavel Machek To: Tony Lindgren , j-keerthy@ti.com, narmstrong@baylibre.com, claudiu.beznea@microchip.com Cc: Sebastian Reichel , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org Subject: Re: Vibrations on Droid 4? Message-ID: <20180801185823.GC26087@amd> References: <20180709081534.GA6799@amd> <20180709214910.tes6u4ivxomd3aja@earth.universe> <20180709220211.GA7760@amd> <20180710101147.lyu65ro4czvrs2da@earth.universe> <20180710133040.GA4391@amd> <20180710161123.azym6sbboriuj4yc@earth.universe> <20180711080218.GA21225@amd> <20180711132739.GL99251@atomide.com> <20180715201729.GB19675@amd> <20180716075926.GU99251@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vOmOzSkFvhd7u8Ms" Content-Disposition: inline In-Reply-To: <20180716075926.GU99251@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vOmOzSkFvhd7u8Ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Yep, so I have two patches that make the device appear, but vibrations > > still do not work for me. > >=20 > > a) any ideas how to debug that / get them to work? >=20 > Hmm no new ideas except I wonder if there is also some other > regression with the timer pdata not being passed properly now. I checked vibrations work in original Motorola Android; my hardware is not broken. I see: commit b7290cf6ff7869ec12070aa146c370728cab62c2 Author: Keerthy Date: Thu Feb 15 11:31:50 2018 +0530 pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. Signed-off-by: Keerthy Acked-by: Neil Armstrong Reviewed-by: Claudiu Beznea Signed-off-by: Tony Lindgren =09 should I try to revert that one? (Are pdata still there in the board files somewhere). Do vibrations work for you? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --vOmOzSkFvhd7u8Ms Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAltiAs8ACgkQMOfwapXb+vJF5wCdEvDRoobAoL6iVOgPyg+w61n6 39QAnAz8PfDiNDfiq4y9xbihCPfH+rUk =EOB9 -----END PGP SIGNATURE----- --vOmOzSkFvhd7u8Ms--