From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8ECC43142 for ; Thu, 2 Aug 2018 10:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 438EE2150A for ; Thu, 2 Aug 2018 10:55:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1+hbtqmH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 438EE2150A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732100AbeHBMqP (ORCPT ); Thu, 2 Aug 2018 08:46:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:49024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727120AbeHBMqP (ORCPT ); Thu, 2 Aug 2018 08:46:15 -0400 Received: from mail.kernel.org (host-091-097-086-007.ewe-ip-backbone.de [91.97.86.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8EE2B214DC; Thu, 2 Aug 2018 10:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1533207337; bh=tbQDPaY5ICMMa+vQhCN5NBJQ9WR9U03kSCMKcKkWMbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1+hbtqmH5C+HWADTU8H/pLS6GQRUwbLbyHhp2UUn8USKltUOlQs6jEabXqYrIYyDJ xnYLTbiC8jnZ+8O98INa3c7T/l0VyEUtV+n4X2/5IfH8+iDMN5c3BKmcg8Ysv0PdRx etkHbocqdnhYhO4efCXdj5yk8JJbxdPjeqB0k5ew= Date: Thu, 2 Aug 2018 12:55:35 +0200 From: Sebastian Reichel To: Pavel Machek Cc: Tony Lindgren , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org Subject: Re: [PATCH] fix vibrations on Droid 4 Message-ID: <20180802105535.2fvggxsma22usrfr@earth.universe> References: <20180709214910.tes6u4ivxomd3aja@earth.universe> <20180709220211.GA7760@amd> <20180710101147.lyu65ro4czvrs2da@earth.universe> <20180710133040.GA4391@amd> <20180710161123.azym6sbboriuj4yc@earth.universe> <20180711080218.GA21225@amd> <20180711132739.GL99251@atomide.com> <20180715201729.GB19675@amd> <20180716075926.GU99251@atomide.com> <20180801202821.GB4033@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cyth6dvy6fl3k6an" Content-Disposition: inline In-Reply-To: <20180801202821.GB4033@amd> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cyth6dvy6fl3k6an Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Aug 01, 2018 at 10:28:21PM +0200, Pavel Machek wrote: > Vibration GPIOs don't have anything to do with wakeup. Move it to > normal section; this fixes vibrations on Droid 4. > =20 > Signed-off-by: Pavel Machek >=20 > diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts= /omap4-droid4-xt894.dts > index c27fc87..7b82179 100644 Reviewed-by: Sebastian Reichel -- Sebastian > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts > @@ -646,15 +646,6 @@ > OMAP4_IOPAD(0x10c, PIN_INPUT | MUX_MODE1) /* abe_mcbsp3_fsx */ > >; > }; > -}; > - > -&omap4_pmx_wkup { > - usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins { > - /* gpio_wk0 */ > - pinctrl-single,pins =3D < > - OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3) > - >; > - }; > =20 > vibrator_direction_pin: pinmux_vibrator_direction_pin { > pinctrl-single,pins =3D < > @@ -669,6 +660,15 @@ > }; > }; > =20 > +&omap4_pmx_wkup { > + usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins { > + /* gpio_wk0 */ > + pinctrl-single,pins =3D < > + OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3) > + >; > + }; > +}; > + > /* > * As uart1 is wired to mdm6600 with rts and cts, we can use the cts pin= for > * uart1 wakeirq. >=20 > --=20 > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/b= log.html --cyth6dvy6fl3k6an Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlti4yMACgkQ2O7X88g7 +pqoGRAAp0IrhrYTJpWM9qcnMX0IYF+Vw4i6VKrymdHSF1JQnb0f4zRkTJ/Qy14U XCZzvwgxJ1EBL/9P3jSx/8zEKaXtIPhedeBbMH9VW7iq3vEAa8zxvU1ee3WM3KFo CsUFB69Y0RE/Ofspz1ZeeAwf+DRCZLIa/R0t9NGTB09q9AaUSCUIuyrOxyQWFZLU gnUSe8Ebi/hDbRFcF9JqtcLXV4hR6S4Y6xQZ1B68qTrWJPSshqJ2dkosnSmenwDk zsj3IxG2r38wVZfZ4Wd7OSxEUrhapT3Ya7OeDOB56LIyARhhRAIPhjQecVPRgebx KUq4B7XNer9OwIhs0OK9KyFbaA1RpV7n5itJYL8aLt/Qonih3I6sewrWEs09s/cL adPGQChYDripApaI4PraefvgKEv/UOue3GHDHkPpBEVO4IFXCWPxiOwP0GB+AG50 SZoC+JxrseCKB9ha4fdaXI0u5v6BnsscJRzSZMag6tzAAnY+Wi5ErhsnnxDd7ZfE k28TxoJwKNe87uDIAuyuP99wwDxwysa9HSgGrlnxEXfFD8aBOT2w9xf6mxFC1jJl JjlmH54jb5KU80bstv1m3jTr5lkHx7vZiWb8t+7Ya/1T23JiH3W4mDSf47Qno4tf Nn0ZCIFmGdhDLXiH9m2vPrfHRsYbXrFV+0wZ9zQh0Gus5U0J81M= =hDVL -----END PGP SIGNATURE----- --cyth6dvy6fl3k6an--