From: Michal Hocko <mhocko@kernel.org>
To: Wei Wang <wei.w.wang@intel.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
mst@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH v2 2/2] virtio_balloon: replace oom notifier with shrinker
Date: Thu, 2 Aug 2018 13:29:01 +0200 [thread overview]
Message-ID: <20180802112901.GH10808@dhcp22.suse.cz> (raw)
In-Reply-To: <5B62EAAC.8000505@intel.com>
On Thu 02-08-18 19:27:40, Wei Wang wrote:
> On 08/02/2018 07:00 PM, Tetsuo Handa wrote:
> > On 2018/08/02 19:32, Wei Wang wrote:
> > > On 08/01/2018 07:34 PM, Michal Hocko wrote:
> > > > Do you have any numbers for how does this work in practice?
> > > It works in this way: for example, we can set the parameter, balloon_pages_to_shrink,
> > > to shrink 1GB memory once shrink scan is called. Now, we have a 8GB guest, and we balloon
> > > out 7GB. When shrink scan is called, the balloon driver will get back 1GB memory and give
> > > them back to mm, then the ballooned memory becomes 6GB.
> > Since shrinker might be called concurrently (am I correct?),
>
> Not sure about it being concurrently, but I think it would be called
> repeatedly as should_continue_reclaim() returns true.
Multiple direct reclaimers might indeed invoke it concurrently.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-08-02 11:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 9:24 [PATCH v2 0/2] virtio-balloon: some improvements Wei Wang
2018-07-27 9:24 ` [PATCH v2 1/2] virtio-balloon: remove BUG() in init_vqs Wei Wang
2018-07-27 9:24 ` [PATCH v2 2/2] virtio_balloon: replace oom notifier with shrinker Wei Wang
2018-07-30 9:00 ` Michal Hocko
2018-08-01 11:12 ` Wei Wang
2018-08-01 11:34 ` Michal Hocko
2018-08-02 10:32 ` Wei Wang
2018-08-02 11:00 ` Tetsuo Handa
2018-08-02 11:27 ` Wei Wang
2018-08-02 11:29 ` Michal Hocko [this message]
2018-08-02 11:47 ` Michal Hocko
2018-08-03 5:35 ` Wei Wang
2018-08-02 15:18 ` Michael S. Tsirkin
2018-07-27 14:06 ` [PATCH v2 0/2] virtio-balloon: some improvements Michael S. Tsirkin
2018-07-28 2:00 ` Wang, Wei W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802112901.GH10808@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).