From: Christoph Hellwig <hch@infradead.org>
To: Alan Kao <alankao@andestech.com>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmer@sifive.com>, Albert Ou <albert@sifive.com>,
Christoph Hellwig <hch@infradead.org>,
Andrew Waterman <andrew@sifive.com>,
Arnd Bergmann <arnd@arndb.de>, Darius Rad <darius@bluespec.com>,
Vincent Chen <vincentc@andestech.com>,
Zong Li <zong@andestech.com>, Nick Hu <nickhu@andestech.com>,
Greentime Hu <greentime@andestech.com>
Subject: Re: [PATCH v3 3/4] Cleanup ISA string setting
Date: Thu, 2 Aug 2018 04:38:42 -0700 [thread overview]
Message-ID: <20180802113842.GC17108@infradead.org> (raw)
In-Reply-To: <1533188391-5932-4-git-send-email-alankao@andestech.com>
On Thu, Aug 02, 2018 at 01:39:50PM +0800, Alan Kao wrote:
> The reason that we cannot follow the review's suggestion in
> https://lkml.org/lkml/2018/6/21/39 is because using "+=" as the
> connector in Makefile introduces blanks bewteen the left-hand
> side alphabets.
That normally goes into the reply to the suggestion, not into the
changelog, so please drop it.
>
> Note: (Assume that atomic and compressed is on)
>
> Before this patch, assembler was always given the riscv64imafdc
> MARCH string because there are fld/fsd's in entry.S; compiler was
> always given riscv64imac because kernel doesn't need floating point
> code generation. After this, the MARCH string in AFLAGS and CFLAGS
> become the same.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-08-02 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 5:39 [PATCH v3 0/4] riscv: Add support to no-FPU systems Alan Kao
2018-08-02 5:39 ` [PATCH v3 1/4] Extract FPU context operations from entry.S Alan Kao
2018-08-02 11:35 ` Christoph Hellwig
2018-08-02 5:39 ` [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures Alan Kao
2018-08-02 11:37 ` Christoph Hellwig
2018-08-03 6:42 ` kbuild test robot
2018-08-02 5:39 ` [PATCH v3 3/4] Cleanup ISA string setting Alan Kao
2018-08-02 11:38 ` Christoph Hellwig [this message]
2018-08-02 5:39 ` [PATCH v3 4/4] Add an option to support no-FPU systems Alan Kao
2018-08-02 11:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802113842.GC17108@infradead.org \
--to=hch@infradead.org \
--cc=alankao@andestech.com \
--cc=albert@sifive.com \
--cc=andrew@sifive.com \
--cc=arnd@arndb.de \
--cc=darius@bluespec.com \
--cc=greentime@andestech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nickhu@andestech.com \
--cc=palmer@sifive.com \
--cc=vincentc@andestech.com \
--cc=zong@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).