* [PATCH net-next] tcp: remove unneeded variable 'err'
@ 2018-08-03 8:28 YueHaibing
2018-08-03 23:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-08-03 8:28 UTC (permalink / raw)
To: edumazet, davem, kuznet, yoshfuji; +Cc: linux-kernel, netdev, YueHaibing
variable 'err' is unmodified after initalization,
so simply cleans up it and returns 0.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/ipv4/tcp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 31fa1c0..b8af2fe 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2531,7 +2531,6 @@ int tcp_disconnect(struct sock *sk, int flags)
struct inet_sock *inet = inet_sk(sk);
struct inet_connection_sock *icsk = inet_csk(sk);
struct tcp_sock *tp = tcp_sk(sk);
- int err = 0;
int old_state = sk->sk_state;
if (old_state != TCP_CLOSE)
@@ -2612,7 +2611,7 @@ int tcp_disconnect(struct sock *sk, int flags)
}
sk->sk_error_report(sk);
- return err;
+ return 0;
}
EXPORT_SYMBOL(tcp_disconnect);
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] tcp: remove unneeded variable 'err'
2018-08-03 8:28 [PATCH net-next] tcp: remove unneeded variable 'err' YueHaibing
@ 2018-08-03 23:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-08-03 23:52 UTC (permalink / raw)
To: yuehaibing; +Cc: edumazet, kuznet, yoshfuji, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 3 Aug 2018 16:28:48 +0800
> variable 'err' is unmodified after initalization,
> so simply cleans up it and returns 0.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-03 23:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-03 8:28 [PATCH net-next] tcp: remove unneeded variable 'err' YueHaibing
2018-08-03 23:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).