[PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

[PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

[zhong jiang]

Fix the following warning.

kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 kernel/kthread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kthread.c b/kernel/kthread.c
index 087d18d..3c661a0 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
 }
 EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
 
-void __kthread_queue_delayed_work(struct kthread_worker *worker,
+static void __kthread_queue_delayed_work(struct kthread_worker *worker,
 				  struct kthread_delayed_work *dwork,
 				  unsigned long delay)
 {
-- 
1.7.12.4

Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

[Steven Rostedt]

On Fri, 3 Aug 2018 20:40:02 +0800
zhong jiang <zhongjiang@huawei.com> wrote:

> Fix the following warning.
> 
> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?


This should go via the trivial tree.

> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  kernel/kthread.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index 087d18d..3c661a0 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
>  }
>  EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
>  
> -void __kthread_queue_delayed_work(struct kthread_worker *worker,
> +static void __kthread_queue_delayed_work(struct kthread_worker *worker,
>  				  struct kthread_delayed_work *dwork,
>  				  unsigned long delay)

Although, one could say you should align the parameters too, but that's
not a big deal. Anyway...

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

>  {

Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

[zhong jiang]

On 2018/8/3 21:21, Steven Rostedt wrote:
> On Fri, 3 Aug 2018 20:40:02 +0800
> zhong jiang <zhongjiang@huawei.com> wrote:
>
>> Fix the following warning.
>>
>> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?
>
> This should go via the trivial tree.
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  kernel/kthread.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/kthread.c b/kernel/kthread.c
>> index 087d18d..3c661a0 100644
>> --- a/kernel/kthread.c
>> +++ b/kernel/kthread.c
>> @@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
>>  }
>>  EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
>>  
>> -void __kthread_queue_delayed_work(struct kthread_worker *worker,
>> +static void __kthread_queue_delayed_work(struct kthread_worker *worker,
>>  				  struct kthread_delayed_work *dwork,
>>  				  unsigned long delay)
> Although, one could say you should align the parameters too, but that's
> not a big deal. Anyway...
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
  Thanks , I will notice for next time.
> -- Steve
>
>>  {
>
> .
>