LKML Archive on
 help / color / Atom feed
From: Marek Szyprowski <>
To: Dmitry Torokhov <>
Cc: Ravi Chandra Sadineni <>,
	Ravi Chandra Sadineni <>,
	Todd Broch <>,
	lkml <>,
	"" <>,
Subject: Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.
Date: Mon, 6 Aug 2018 09:15:42 +0200
Message-ID: <> (raw)
In-Reply-To: <>

Hi Dmitry

On 2018-08-06 08:16, Dmitry Torokhov wrote:
> On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski
> <> wrote:
>> Hi Ravi,
>> On 2018-08-03 18:53, Ravi Chandra Sadineni wrote:
>>> Understood. I am trying to reproduce this issue locally. Wanted to
>>> know the version of the kernel so I can give a try. Marek, can you
>>> please confirm the kernel version.
>> Yes, sorry for the missing context, I was in hurry writing the report and
>> I wanted to send it before leaving the office. I'm testing mainline on Snow
>> with exynos_defconfig.
>> Suspend/resume is partially broken already with mainline, but if you disable
>> CPUfreq support, it works fine on Linux v4.17.
>> I've posted CPUfreq related fixes here if you are interested:
>> The issue with cros_ec_keyb patch appears first on Linux v4.18-rc1, which is
>> the first release with that patch.
> Marek, this patch should only be in -next, I do not believe I sent it
> to Linus just yet. If mainline is broken for you it can't be caused by
> this patch.

Aaahh. My fault then. The suspend/resume issue is cause by commit
38ba34a43dbc ("Input: cros_ec_keyb - mark cros_ec_keyb driver as wake
enabled device."), which has been merged to v4.18-rc1.

It looks that I've downloaded wrong patch from the patchwork to reply it
with a a bug report. :( I'm really sorry for the noise in the wrong thread.

Ravi: please let me know how can I help you to debug this issue.

>> Linux -next from 20180803, which has a few
>> more patches for cros_ec_keyb suffers from the same issue.
> Just to confirm, if you revert only this patch from -next you get
> suspend/resume back?
> Thanks.

Best regards
Marek Szyprowski, PhD
Samsung R&D Institute Poland

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 22:44 Ravi Chandra Sadineni
2018-06-12 23:32 ` Dmitry Torokhov
     [not found] ` <>
2018-08-03  7:26   ` Marek Szyprowski
     [not found]     ` <>
2018-08-03 16:07       ` Dmitry Torokhov
     [not found]         ` <>
2018-08-06  5:29           ` Marek Szyprowski
2018-08-06  6:16             ` Dmitry Torokhov
2018-08-06  7:15               ` Marek Szyprowski [this message]
2018-08-06 23:05                 ` Ravi Chandra Sadineni
2018-08-07 21:59                   ` Ravi Chandra Sadineni
2018-08-08  5:03                     ` Marek Szyprowski
     [not found]                     ` <>
2018-08-10  8:23                       ` Marek Szyprowski
2018-08-17 21:21                         ` RaviChandra Sadineni
2018-08-20  8:52                           ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone