From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A8BC46471 for ; Mon, 6 Aug 2018 13:47:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A73E208E6 for ; Mon, 6 Aug 2018 13:47:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A73E208E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730203AbeHFP4N (ORCPT ); Mon, 6 Aug 2018 11:56:13 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56558 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727582AbeHFP4N (ORCPT ); Mon, 6 Aug 2018 11:56:13 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 853187C6CA; Mon, 6 Aug 2018 13:47:01 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.34.27.30]) by smtp.corp.redhat.com (Postfix) with SMTP id 55A072156897; Mon, 6 Aug 2018 13:46:59 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 6 Aug 2018 15:47:01 +0200 (CEST) Date: Mon, 6 Aug 2018 15:46:58 +0200 From: Oleg Nesterov To: Jiri Olsa Cc: Jiri Olsa , Arnaldo Carvalho de Melo , Milind Chabbi , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Alexander Shishkin , Peter Zijlstra , Frederic Weisbecker Subject: Re: [PATCH 2/2] perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set Message-ID: <20180806134658.GE7840@redhat.com> References: <20180806101241.6444-1-jolsa@kernel.org> <20180806101241.6444-3-jolsa@kernel.org> <20180806124839.GC7840@redhat.com> <20180806132353.GA7463@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180806132353.GA7463@krava> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 06 Aug 2018 13:47:01 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 06 Aug 2018 13:47:01 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'oleg@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06, Jiri Olsa wrote: > > > Afaics you do not need to clear attr.disabled, modify_user_hw_breakpoint_check() > > updates it if err = 0. So I think > > > > if (!bp->attr.disabled) > > perf_event_enable(bp); > > > > will look a bit better. > > > > > > But, with or without this fix, shouldn't we set .disabled = 1 if modify_() fails? > > IIUC this doesn't matter, bp->attr.disabled is not really used anyway, but looks a > > bit confusing. > > > > yea, I was looking on that, but as u said it makes no difference > and I wanted to keep the patch as simple as possible ;-) OK. So both patches look good to me. Acked-by: Oleg Nesterov