From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAEEC46471 for ; Mon, 6 Aug 2018 14:58:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B42F20891 for ; Mon, 6 Aug 2018 14:58:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B42F20891 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732496AbeHFRID (ORCPT ); Mon, 6 Aug 2018 13:08:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:53100 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732197AbeHFRID (ORCPT ); Mon, 6 Aug 2018 13:08:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E49B2AED9; Mon, 6 Aug 2018 14:58:33 +0000 (UTC) Date: Mon, 6 Aug 2018 16:58:33 +0200 From: Michal Hocko To: Tetsuo Handa Cc: syzbot , cgroups@vger.kernel.org, dvyukov@google.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, vdavydov.dev@gmail.com, David Howells Subject: Re: WARNING in try_charge Message-ID: <20180806145833.GA8607@dhcp22.suse.cz> References: <884de816-671a-44d4-a6a1-2ad7eff53715@I-love.SAKURA.ne.jp> <00000000000070698b0572c28ebc@google.com> <20180806113212.GK19540@dhcp22.suse.cz> <39db7dbc-fedf-a86e-3c8b-0192e83d3c8d@i-love.sakura.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39db7dbc-fedf-a86e-3c8b-0192e83d3c8d@i-love.sakura.ne.jp> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 06-08-18 23:41:22, Tetsuo Handa wrote: > +David Howells > > On 2018/08/06 20:32, Michal Hocko wrote: > > On Mon 06-08-18 04:27:02, syzbot wrote: > >> Hello, > >> > >> syzbot has tested the proposed patch and the reproducer did not trigger > >> crash: > >> > >> Reported-and-tested-by: > >> syzbot+bab151e82a4e973fa325@syzkaller.appspotmail.com > >> > >> Tested on: > >> > >> commit: 8c8399e0a3fb Add linux-next specific files for 20180806 > >> git tree: linux-next > >> kernel config: https://syzkaller.appspot.com/x/.config?x=1b6bc1781e49e93e > >> compiler: gcc (GCC) 8.0.1 20180413 (experimental) > >> patch: https://syzkaller.appspot.com/x/patch.diff?x=14fe18e2400000 > >> > >> Note: testing is done by a robot and is best-effort only. > > > > OK, so this smells like a problem in the previous group oom changes. Or > > maybe it is not very easy to reproduce? > > > > Since I can't find mm related changes between next-20180803 (syzbot can reproduce) and > next-20180806 (syzbot has not reproduced), I can't guess what makes this problem go away. Hmm, but original report was against 4.18.0-rc6-next-20180725+ kernel. And that one had the old group oom code. /me confused. -- Michal Hocko SUSE Labs