* [PATCH] net: thunderx: check for failed allocation lmac->dmacs
@ 2018-08-06 16:50 Colin King
2018-08-07 19:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-08-06 16:50 UTC (permalink / raw)
To: Sunil Goutham, Robert Richter, David S . Miller,
linux-arm-kernel, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The allocation of lmac->dmacs is not being checked for allocation
failure. Add the check.
Fixes: 3a34ecfd9d3f ("net: thunderx: add MAC address filter tracking for LMAC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 5d08d2aeb172..e337da6ba2a4 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1083,6 +1083,8 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid)
lmac->dmacs_count = (RX_DMAC_COUNT / bgx->lmac_count);
lmac->dmacs = kcalloc(lmac->dmacs_count, sizeof(*lmac->dmacs),
GFP_KERNEL);
+ if (!lmac->dmacs)
+ return -ENOMEM;
/* Enable lmac */
bgx_reg_modify(bgx, lmacid, BGX_CMRX_CFG, CMR_EN);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: thunderx: check for failed allocation lmac->dmacs
2018-08-06 16:50 [PATCH] net: thunderx: check for failed allocation lmac->dmacs Colin King
@ 2018-08-07 19:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-08-07 19:38 UTC (permalink / raw)
To: colin.king
Cc: sgoutham, rric, linux-arm-kernel, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 6 Aug 2018 17:50:45 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The allocation of lmac->dmacs is not being checked for allocation
> failure. Add the check.
>
> Fixes: 3a34ecfd9d3f ("net: thunderx: add MAC address filter tracking for LMAC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-07 19:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 16:50 [PATCH] net: thunderx: check for failed allocation lmac->dmacs Colin King
2018-08-07 19:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).