From: Andrew Lunn <andrew@lunn.ch>
To: Kosta Zertsekel <zertsekel@gmail.com>
Cc: "Mark Brown" <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jan Kundrát" <jan.kundrat@cesnet.cz>,
"Stefan Roese" <sr@denx.de>,
"Ken Wilson" <ken.wilson@opengear.com>
Subject: Re: [PATCH v2] spi: orion: cosmetics - alias long direct_access variables
Date: Mon, 6 Aug 2018 22:06:40 +0200 [thread overview]
Message-ID: <20180806200640.GL9372@lunn.ch> (raw)
In-Reply-To: <20180806195002.15156-1-zertsekel@gmail.com>
On Mon, Aug 06, 2018 at 10:50:02PM +0300, Kosta Zertsekel wrote:
> This change increases the source code readability.
> Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`.
Hi Kosta
You forgot to update this line.
Please wait a week to allow others to comment, then submit a v3, and
include:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-08-06 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 19:50 [PATCH v2] spi: orion: cosmetics - alias long direct_access variables Kosta Zertsekel
2018-08-06 20:06 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-06 19:43 Kosta Zertsekel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806200640.GL9372@lunn.ch \
--to=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=jan.kundrat@cesnet.cz \
--cc=ken.wilson@opengear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sr@denx.de \
--cc=zertsekel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).