From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: kan.liang@linux.intel.com, tglx@linutronix.de, mingo@redhat.com,
acme@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, alexander.shishkin@linux.intel.com
Subject: Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler
Date: Mon, 6 Aug 2018 23:50:06 +0200 [thread overview]
Message-ID: <20180806215005.GU2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180806213323.GK4238@tassilo.jf.intel.com>
On Mon, Aug 06, 2018 at 02:33:23PM -0700, Andi Kleen wrote:
> On Mon, Aug 06, 2018 at 08:35:15PM +0200, Peter Zijlstra wrote:
> > > +static bool disable_counter_freezing;
> > > +module_param(disable_counter_freezing, bool, 0444);
> > > +MODULE_PARM_DESC(disable_counter_freezing, "Disable counter freezing feature."
> > > + "The PMI handler will fall back to generic handler."
> > > + "Default is false (enable counter freezing feature).");
> >
> > Why?
>
> See the description. Counter freezing took some time to stabilize,
> so it seemed better to have a knob to ask users to try in case
> there are more problems.
But it is not a module.. did you want early_param() or __setup()?
> > > + /*
> > > + * Ack the PMU late after the APIC. This avoids bogus
> >
> > > + * freezing on Skylake CPUs. The acking unfreezes the PMU
> > > + */
> > That doesn't make sense. PMU and APIC do not have order.>
>
> It makes a difference for the hardware.
I still have no clue what it wants to say.
> > > + /*
> > > + * For arch perfmon 4 use counter freezing to avoid
> > > + * several MSR accesses in the PMI.
> > > + */
> > > + if (x86_pmu.counter_freezing) {
> > > + x86_pmu.handle_irq = intel_pmu_handle_irq_v4;
> > > + pr_cont("counter freezing, ");
> > > + }
> >
> > Lets not print the counter freezing, we already print v4, right?
>
> I find it useful to see that the kernel has the support, otherwise
> you would need to look at the version number, but it gets difficult
> with backports. This is another paranoia bit, in case there
> are problems.
That line will get ver long if we keep adding every dinky bit to it.
> > > @@ -561,6 +566,7 @@ struct x86_pmu {
> > > struct x86_pmu_quirk *quirks;
> > > int perfctr_second_write;
> > > bool late_ack;
> > > + bool counter_freezing;
> >
> > Please make the both of them int or something.
>
> That would make them bigger for no reason?
Then use u8 or something, I just don't much like _Bool in composite
types.
next prev parent reply other threads:[~2018-08-06 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 17:23 [PATCH 1/3] perf/x86/intel: Factor out common code of PMI handler kan.liang
2018-08-06 17:23 ` [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 " kan.liang
2018-08-06 18:35 ` Peter Zijlstra
2018-08-06 21:33 ` Andi Kleen
2018-08-06 21:50 ` Peter Zijlstra [this message]
2018-08-07 15:29 ` Liang, Kan
2018-08-07 17:31 ` Peter Zijlstra
2018-08-06 17:23 ` [PATCH 3/3] perf/x86/intel: Add quirk for Goldmont Plus kan.liang
2018-08-06 18:39 ` Peter Zijlstra
2018-08-07 15:30 ` Liang, Kan
2018-08-06 18:20 ` [PATCH 1/3] perf/x86/intel: Factor out common code of PMI handler Peter Zijlstra
2018-08-07 15:29 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806215005.GU2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).