From: Peter Zijlstra <peterz@infradead.org>
To: Fubo Chen <fubo.chen@gmail.com>
Cc: jpoimboe@redhat.com, Ingo Molnar <mingo@kernel.org>,
bhole_prashant_q7@lab.ntt.co.jp,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)
Date: Tue, 7 Aug 2018 11:05:44 +0200 [thread overview]
Message-ID: <20180807090544.GX2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJAFBLDzX78w=uaTdBQ_obb9hBMLGXG1Ec0hb199HEXxXQBPjQ@mail.gmail.com>
On Mon, Aug 06, 2018 at 04:04:40PM -0700, Fubo Chen wrote:
> On Mon, Aug 6, 2018 at 3:30 PM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Mon, Aug 06, 2018 at 02:28:18PM -0700, Fubo Chen wrote:
> > > Do you think the patch below is sufficient to suppress the sparse warning?
> >
> > Why would I want to make the code ugly to supress it?
>
> There are many kernel developers who use sparse to verify the
> correctness of endianness annotations (__be32, __le32, ...). When
> compiling kernel code with sparse every warning that is reported by
> sparse should be analyzed. Most kernel developers consider it annoying
> having to deal with false positive warnings. So I think that is useful
> to suppress false positive sparse warnings if it is possible to
> suppress false positives with a reasonable effort.
Last time I used sparse there were a metric ton of warnings. I really
can't be bothered about one more. Maybe fix sparse if you're bothered?
prev parent reply other threads:[~2018-08-07 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 4:33 BUG: KASAN: stack-out-of-bounds in unwind_next_frame Prashant Bhole
2018-07-19 15:33 ` Josh Poimboeuf
2018-07-19 17:43 ` Peter Zijlstra
2018-07-19 21:19 ` [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II) Peter Zijlstra
2018-07-19 22:45 ` kbuild test robot
2018-07-19 23:54 ` kbuild test robot
2018-07-23 13:30 ` Josh Poimboeuf
2018-07-23 14:14 ` Peter Zijlstra
2018-07-24 16:35 ` Josh Poimboeuf
2018-08-06 15:35 ` Fubo Chen
2018-08-06 15:42 ` Peter Zijlstra
2018-08-06 16:54 ` Fubo Chen
2018-08-06 18:04 ` Peter Zijlstra
2018-08-06 21:28 ` Fubo Chen
2018-08-06 22:30 ` Peter Zijlstra
2018-08-06 23:04 ` Fubo Chen
2018-08-07 9:05 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807090544.GX2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=fubo.chen@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).