Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.

From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Ravi Chandra Sadineni <ravisadineni@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Ravi Chandra Sadineni <ravisadineni@google.com>,
	Todd Broch <tbroch@google.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.
Date: Wed, 8 Aug 2018 07:03:24 +0200	[thread overview]
Message-ID: <20180808050325eucas1p1fb0792e2a8490fa3eebdfdaa6165038c~I0DZ-C69N2154421544eucas1p1X@eucas1p1.samsung.com> (raw)
In-Reply-To: <CAEZbON5vMOiYRsnN1MyuSov3URByeAp-z3EEsEH6tqY23U32wQ@mail.gmail.com>

Hi Ravi,

On 2018-08-07 23:59, Ravi Chandra Sadineni wrote:
> hi Merek,
>
> I tried booting a snow device and could not get it to boot it to the
> console. I assume i don't have right kernel config. Can you share your
> config if possible.

I use standard exynos_defconfig bundled with Linux kernel. I've followed
this instruction to boot in on Snow:

https://s-opensource.org/2016/03/24/use-mainline-u-boot-non-signed-kernels-exynos-chromebooks/

>
> Thanks,
> RaviOn Mon, Aug 6, 2018 at 4:05 PM Ravi Chandra Sadineni
> <ravisadineni@chromium.org> wrote:
>> Hi Merek,
>>
>> Thanks for the info. Lemme understand what's going on. Will update the
>> thread once I have more info.
>>
>> Thanks,
>> Ravi
>> On Mon, Aug 6, 2018 at 12:15 AM Marek Szyprowski
>> <m.szyprowski@samsung.com> wrote:
>>> Hi Dmitry
>>>
>>> On 2018-08-06 08:16, Dmitry Torokhov wrote:
>>>> On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski
>>>> <m.szyprowski@samsung.com> wrote:
>>>>> Hi Ravi,
>>>>>
>>>>> On 2018-08-03 18:53, Ravi Chandra Sadineni wrote:
>>>>>> Understood. I am trying to reproduce this issue locally. Wanted to
>>>>>> know the version of the kernel so I can give a try. Marek, can you
>>>>>> please confirm the kernel version.
>>>>>>
>>>>> Yes, sorry for the missing context, I was in hurry writing the report and
>>>>> I wanted to send it before leaving the office. I'm testing mainline on Snow
>>>>> with exynos_defconfig.
>>>>>
>>>>> Suspend/resume is partially broken already with mainline, but if you disable
>>>>> CPUfreq support, it works fine on Linux v4.17.
>>>>>
>>>>> I've posted CPUfreq related fixes here if you are interested:
>>>>> https://patchwork.kernel.org/patch/10554607/
>>>>> https://patchwork.kernel.org/patch/10554603/
>>>>>
>>>>> The issue with cros_ec_keyb patch appears first on Linux v4.18-rc1, which is
>>>>> the first release with that patch.
>>>> Marek, this patch should only be in -next, I do not believe I sent it
>>>> to Linus just yet. If mainline is broken for you it can't be caused by
>>>> this patch.
>>> Aaahh. My fault then. The suspend/resume issue is cause by commit
>>> 38ba34a43dbc ("Input: cros_ec_keyb - mark cros_ec_keyb driver as wake
>>> enabled device."), which has been merged to v4.18-rc1.
>>>
>>> It looks that I've downloaded wrong patch from the patchwork to reply it
>>> with a a bug report. :( I'm really sorry for the noise in the wrong thread.
>>>
>>> Ravi: please let me know how can I help you to debug this issue.
>>>
>>>>> Linux -next from 20180803, which has a few
>>>>> more patches for cros_ec_keyb suffers from the same issue.
>>>> Just to confirm, if you revert only this patch from -next you get
>>>> suspend/resume back?
>>>>
>>>> Thanks.
>>> Best regards
>>> --
>>> Marek Szyprowski, PhD
>>> Samsung R&D Institute Poland
>>>
>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland