LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net-next] decnet: fix using plain integer as NULL warning
@ 2018-08-08 11:59 YueHaibing
  2018-08-08 22:03 ` Kees Cook
  2018-08-09 21:12 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-08-08 11:59 UTC (permalink / raw)
  To: davem
  Cc: linux-kernel, netdev, keescook, edumazet, linux-decnet-user, YueHaibing

Fixes the following sparse warning:
net/decnet/dn_route.c:407:30: warning: Using plain integer as NULL pointer
net/decnet/dn_route.c:1923:22: warning: Using plain integer as NULL pointer

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 net/decnet/dn_route.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 3107a2e..1c002c0 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -404,7 +404,7 @@ void dn_rt_cache_flush(int delay)
 
 	if (delay <= 0) {
 		spin_unlock_bh(&dn_rt_flush_lock);
-		dn_run_flush(0);
+		dn_run_flush(NULL);
 		return;
 	}
 
@@ -1920,7 +1920,7 @@ void __init dn_route_init(void)
 void __exit dn_route_cleanup(void)
 {
 	del_timer(&dn_route_timer);
-	dn_run_flush(0);
+	dn_run_flush(NULL);
 
 	remove_proc_entry("decnet_cache", init_net.proc_net);
 	dst_entries_destroy(&dn_dst_ops);
-- 
2.7.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] decnet: fix using plain integer as NULL warning
  2018-08-08 11:59 [PATCH net-next] decnet: fix using plain integer as NULL warning YueHaibing
@ 2018-08-08 22:03 ` Kees Cook
  2018-08-09 21:12 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2018-08-08 22:03 UTC (permalink / raw)
  To: YueHaibing
  Cc: David S. Miller, LKML, Network Development, Eric Dumazet,
	linux-decnet-user

On Wed, Aug 8, 2018 at 4:59 AM, YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes the following sparse warning:
> net/decnet/dn_route.c:407:30: warning: Using plain integer as NULL pointer
> net/decnet/dn_route.c:1923:22: warning: Using plain integer as NULL pointer
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook
Pixel Security

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] decnet: fix using plain integer as NULL warning
  2018-08-08 11:59 [PATCH net-next] decnet: fix using plain integer as NULL warning YueHaibing
  2018-08-08 22:03 ` Kees Cook
@ 2018-08-09 21:12 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-08-09 21:12 UTC (permalink / raw)
  To: yuehaibing; +Cc: linux-kernel, netdev, keescook, edumazet, linux-decnet-user

From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 8 Aug 2018 19:59:32 +0800

> Fixes the following sparse warning:
> net/decnet/dn_route.c:407:30: warning: Using plain integer as NULL pointer
> net/decnet/dn_route.c:1923:22: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-08 11:59 [PATCH net-next] decnet: fix using plain integer as NULL warning YueHaibing
2018-08-08 22:03 ` Kees Cook
2018-08-09 21:12 ` David Miller

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox