linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: linux-riscv@lists.infradead.org,
	Christoph Hellwig <hch@infradead.org>,
	aou@eecs.berkeley.edu, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, tklauser@distanz.ch,
	Marcus Comstedt <marcus@mc.pp.se>
Subject: Re: [PATCH v2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h
Date: Wed, 8 Aug 2018 22:58:30 -0700	[thread overview]
Message-ID: <20180809055830.GA17533@infradead.org> (raw)
In-Reply-To: <20180806204258.22280-2-palmer@sifive.com>

This actually seems to break the compilation for me in for-next:

hch@carbon:~/work/linux$ make ARCH=riscv
  CALL    scripts/checksyscalls.sh
<stdin>:1335:2: warning: #warning syscall rseq not implemented [-Wcpp]
  CHK     include/generated/compile.h
  CC      arch/riscv/kernel/syscall_table.o
./arch/riscv/include/uapi/asm/syscalls.h:29:36: error: 'sys_riscv_flush_icache' undeclared here (not in a function); did you mean '__NR_riscv_flush_icache'?
 __SYSCALL(__NR_riscv_flush_icache, sys_riscv_flush_icache)
                                    ^
arch/riscv/kernel/syscall_table.c:21:37: note: in definition of macro '__SYSCALL'
 #define __SYSCALL(nr, call) [nr] = (call),
                                     ^~~~
make[1]: *** [scripts/Makefile.build:318: arch/riscv/kernel/syscall_table.o] Error 1
make: *** [Makefile:1029: arch/riscv/kernel] Error 2

Reverting it for now, but I guess this might hit others too..

  parent reply	other threads:[~2018-08-09  5:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180803195344.22271-1-palmer@sifive.com>
2018-08-04  8:54 ` [PATCH] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h Christoph Hellwig
2018-08-06 20:42   ` Palmer Dabbelt
2018-08-06 20:42     ` [PATCH v2] " Palmer Dabbelt
2018-08-06 21:00       ` Randy Dunlap
2018-08-07  0:11         ` Palmer Dabbelt
2018-08-07 12:45       ` Christoph Hellwig
2018-08-09  5:58       ` Christoph Hellwig [this message]
2018-08-09 20:58         ` Palmer Dabbelt
2018-08-09 13:26 ` [PATCH] " Guenter Roeck
2018-08-09 20:58   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809055830.GA17533@infradead.org \
    --to=hch@infradead.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=marcus@mc.pp.se \
    --cc=palmer@sifive.com \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).