From: Sudeep Holla <sudeep.holla@arm.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Wei-Ning Huang <wnhuang@chromium.org>,
Julius Werner <jwerner@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Samuel Holland <samuel@sholland.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2 1/2] firmware: coreboot: Let OF core populate platform device
Date: Thu, 9 Aug 2018 10:15:40 +0100 [thread overview]
Message-ID: <20180809091540.GA1324@e107155-lin> (raw)
In-Reply-To: <20180808172414.29983-2-swboyd@chromium.org>
On Wed, Aug 08, 2018 at 10:24:13AM -0700, Stephen Boyd wrote:
> Now that the /firmware/coreboot node in DT is populated by the core DT
> platform code with commit 3aa0582fdb82 ("of: platform: populate
> /firmware/ node from of_platform_default_populate_init()") we should and
> can remove the platform device creation here. Otherwise, the
> of_platform_device_create() call will fail, the coreboot of driver won't
> be registered, and this driver will never bind. At the same time, we
> should move this driver to use MODULE_DEVICE_TABLE so that module
> auto-load works properly when the coreboot device is auto-populated and
> we should drop the of_node handling that was presumably placed here to
> hold a reference to the DT node created during module init that no
> longer happens.
>
> Cc: Wei-Ning Huang <wnhuang@chromium.org>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: Sudeep Holla <Sudeep.Holla@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-08-09 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 17:24 [PATCH v2 0/2] firmware: coreboot: Fix probe and simplify code Stephen Boyd
2018-08-08 17:24 ` [PATCH v2 1/2] firmware: coreboot: Let OF core populate platform device Stephen Boyd
2018-08-09 9:15 ` Sudeep Holla [this message]
2018-08-08 17:24 ` [PATCH v2 2/2] firmware: coreboot: Collapse platform drivers into bus core Stephen Boyd
2018-08-08 19:07 ` Julius Werner
2018-08-08 23:42 ` Stephen Boyd
2018-08-09 19:33 ` kbuild test robot
2018-08-09 22:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809091540.GA1324@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sholland.org \
--cc=swboyd@chromium.org \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).