From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH mmc-next v3 0/3] solve SDHCI DWC MSHC 128MB DMA boundary limitation
Date: Thu, 9 Aug 2018 10:27:59 +0800 [thread overview]
Message-ID: <20180809102759.191d211e@xhacker.debian> (raw)
In-Reply-To: <20180730104228.28b58bd0@xhacker.debian>
Hi Adrian, Ulf,
could you please review these patches? Any comments are welcome.
Thanks in advance,
Jisheng
On Mon, 30 Jul 2018 10:42:28 +0800 Jisheng Zhang wrote:
> When using DMA, if the DMA addr spans 128MB boundary, we have to split
> the DMA transfer into two so that each one doesn't exceed the boundary.
>
> patch1 adds adma_table_num to struct sdhci_host so that driver can
> control the ADMA table number.
> patch2 introduces adma_write_desc() hook to struct sdhci_ops so that
> driver can override it.
> patch3 finally solves the 128MB boundary limitation.
>
> since v2:
> - make use of "likely" to check (!len || BOUNDARY_OK(addr, len))
> - explictly include <linux/sizes.h> for SZ_128M
>
> since v1:
> - fix BOUNDARY_OK macro if addr+len is aligned to 128MB
> - use DIV_ROUND_UP to cal extra desc num
> - fix !len for dwcmshc_adma_write_desc()
>
> Jisheng Zhang (3):
> mmc: sdhci: add adma_table_num member to struct sdhci_host
> mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops
> mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation
>
> drivers/mmc/host/sdhci-of-dwcmshc.c | 43 ++++++++++++++++++++++++++
> drivers/mmc/host/sdhci.c | 48 +++++++++++++++++++----------
> drivers/mmc/host/sdhci.h | 8 +++++
> 3 files changed, 83 insertions(+), 16 deletions(-)
>
prev parent reply other threads:[~2018-08-09 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 2:42 [PATCH mmc-next v3 0/3] solve SDHCI DWC MSHC 128MB DMA boundary limitation Jisheng Zhang
2018-07-30 2:45 ` [PATCH mmc-next v3 2/3] mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops Jisheng Zhang
2018-08-15 14:07 ` Adrian Hunter
2018-07-30 2:46 ` [PATCH mmc-next v3 3/3] mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation Jisheng Zhang
[not found] ` <01010164e91d7bda-aa616cbf-7bb2-4fe4-85e5-a18e16433fde-000000@us-west-2.amazonses.com>
2018-07-30 2:59 ` Jisheng Zhang
[not found] ` <01010164e92bcc1a-c3ac69eb-f6e5-4420-ac87-de1a0ffd0ac5-000000@us-west-2.amazonses.com>
2018-07-30 3:11 ` Jisheng Zhang
2018-08-09 2:27 ` Jisheng Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809102759.191d211e@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=adrian.hunter@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).