From: Wolfram Sang <wsa@the-dreams.de>
To: George Cherian <george.cherian@cavium.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
jglauber@cavium.com
Subject: Re: [PATCH v2] i2c: xlp9xx: Fix case where SSIF read transaction completes early
Date: Thu, 9 Aug 2018 17:42:52 +0200 [thread overview]
Message-ID: <20180809154251.twazp6scrs57sih5@ninjato> (raw)
In-Reply-To: <20180809153959.y6su5kxnwilkdhlz@ninjato>
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
On Thu, Aug 09, 2018 at 05:39:59PM +0200, Wolfram Sang wrote:
> On Wed, Aug 08, 2018 at 11:36:48PM -0700, George Cherian wrote:
> > During ipmi stress tests we see occasional failure of transactions
> > at the boot time. This happens in the case of a I2C_M_RECV_LEN
> > transactions, when the read transfer completes (with the initial
> > read length of 34) before the driver gets a chance to handle interrupts.
> >
> > The current driver code expects at least 2 interrupts for I2C_M_RECV_LEN
> > transactions. The length is updated during the first interrupt, and the
> > buffer contents are only copied during subsequent interrupts. In case of
> > just one interrupt, we will complete the transaction without copying
> > out the bytes from RX fifo.
> >
> > Update the code to drain the RX fifo after the length update,
> > so that the transaction completes correctly in all cases.
> >
> > Signed-off-by: George Cherian <george.cherian@cavium.com>
>
> Applied to for-current, thanks!
...and added stable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-08-09 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 6:36 [PATCH v2] i2c: xlp9xx: Fix case where SSIF read transaction completes early George Cherian
2018-08-09 15:39 ` Wolfram Sang
2018-08-09 15:42 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809154251.twazp6scrs57sih5@ninjato \
--to=wsa@the-dreams.de \
--cc=george.cherian@cavium.com \
--cc=jglauber@cavium.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).