From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 654F9C46460 for ; Thu, 9 Aug 2018 17:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1807921EFA for ; Thu, 9 Aug 2018 17:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Tp5r8tRA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1807921EFA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732662AbeHITnO (ORCPT ); Thu, 9 Aug 2018 15:43:14 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:45179 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732368AbeHITnN (ORCPT ); Thu, 9 Aug 2018 15:43:13 -0400 Received: by mail-pl0-f66.google.com with SMTP id j8-v6so2811129pll.12 for ; Thu, 09 Aug 2018 10:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uiThRTKbWGcq1ih4QLhyY+amPXZ5A4gzmw70r/DuB34=; b=Tp5r8tRAChu7H1tjdI6WgmnLSbn1UqGG8fgro/0z4rZGLSOJsZpzpH3WBofANLrcTv aqy+6zkWdARycirXd2A4LwNsDWSRWEXhLWi1tZPRitGdw55ELlDZyesjQt1qaxB4TQpC GmNRSzQg/h4/r1b4u+hSnOpxlL4b8zxUUB0js= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uiThRTKbWGcq1ih4QLhyY+amPXZ5A4gzmw70r/DuB34=; b=Ak7XoTDo3AZENixdHi4J4NBp/J55TOQlrR4JqHHbknQp2PGhW4HLcoDaU/ejk3ZmNY /db9ccq1zasAVYqnkNFBRBxw2siIxPtJE5Es8Mqz2shhzyQheEAiPea4LzAQkFpzW53z yI/KdfnPXkLvNhrqqJFRf38BXQnSCUYCylnUZkTAQJCnfCsms8/d2eNm2Bm3xRIbxm2s L/ZY6XSRRWkfs4N7aCnwELS4EHLm83pmtlJ+098sZg8dJaMemt8a1s5eyJObOf/TtlOQ zN2bz4yEktU3sZfPHSb7kM+W16GN3lVFSTV6xo97vJ9IB2CipUOc9wRmNHatrhDQcJ4F DCfA== X-Gm-Message-State: AOUpUlEkDxV51Fwuys2qLpcEcwImpMA5SobL2ANx5rfGlEpJ2QOr7KXU gzYuDac7//69KJMDpjQ+7bDz8aDB/kJI9A== X-Google-Smtp-Source: AA+uWPz6+LuuIbPqBju3HcR38e//9qCbqYBOOZ/TSEmtfJOUcA+6XhZD4lq5AVb1etfZCdpgsHFUcQ== X-Received: by 2002:a17:902:4401:: with SMTP id k1-v6mr2799784pld.97.1533835044700; Thu, 09 Aug 2018 10:17:24 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:7e28:b9f3:6afc:5326]) by smtp.gmail.com with ESMTPSA id d75-v6sm12866009pfd.49.2018.08.09.10.17.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 10:17:24 -0700 (PDT) From: Stephen Boyd To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Wei-Ning Huang , Julius Werner , Brian Norris , Samuel Holland Subject: [PATCH v3 1/7] firmware: coreboot: Let OF core populate platform device Date: Thu, 9 Aug 2018 10:17:16 -0700 Message-Id: <20180809171722.144325-2-swboyd@chromium.org> X-Mailer: git-send-email 2.18.0.597.ga71716f1ad-goog In-Reply-To: <20180809171722.144325-1-swboyd@chromium.org> References: <20180809171722.144325-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that the /firmware/coreboot node in DT is populated by the core DT platform code with commit 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") we should and can remove the platform device creation here. Otherwise, the of_platform_device_create() call will fail, the coreboot of driver won't be registered, and this driver will never bind. At the same time, we should move this driver to use MODULE_DEVICE_TABLE so that module auto-load works properly when the coreboot device is auto-populated and we should drop the of_node handling that was presumably placed here to hold a reference to the DT node created during module init that no longer happens. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Reviewed-by: Sudeep Holla Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table-of.c | 28 +++------------------ 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/firmware/google/coreboot_table-of.c b/drivers/firmware/google/coreboot_table-of.c index f15bf404c579..9b90c0fa4a0b 100644 --- a/drivers/firmware/google/coreboot_table-of.c +++ b/drivers/firmware/google/coreboot_table-of.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include "coreboot_table.h" @@ -30,7 +29,6 @@ static int coreboot_table_of_probe(struct platform_device *pdev) void __iomem *ptr; ptr = of_iomap(fw_dn, 0); - of_node_put(fw_dn); if (!ptr) return -ENOMEM; @@ -44,8 +42,9 @@ static int coreboot_table_of_remove(struct platform_device *pdev) static const struct of_device_id coreboot_of_match[] = { { .compatible = "coreboot" }, - {}, + {} }; +MODULE_DEVICE_TABLE(of, coreboot_of_match); static struct platform_driver coreboot_table_of_driver = { .probe = coreboot_table_of_probe, @@ -55,28 +54,7 @@ static struct platform_driver coreboot_table_of_driver = { .of_match_table = coreboot_of_match, }, }; - -static int __init platform_coreboot_table_of_init(void) -{ - struct platform_device *pdev; - struct device_node *of_node; - - /* Limit device creation to the presence of /firmware/coreboot node */ - of_node = of_find_node_by_path("/firmware/coreboot"); - if (!of_node) - return -ENODEV; - - if (!of_match_node(coreboot_of_match, of_node)) - return -ENODEV; - - pdev = of_platform_device_create(of_node, "coreboot_table_of", NULL); - if (!pdev) - return -ENODEV; - - return platform_driver_register(&coreboot_table_of_driver); -} - -module_init(platform_coreboot_table_of_init); +module_platform_driver(coreboot_table_of_driver); MODULE_AUTHOR("Google, Inc."); MODULE_LICENSE("GPL"); -- Sent by a computer through tubes