From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04F5C4646D for ; Fri, 10 Aug 2018 06:03:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 633CD223BF for ; Fri, 10 Aug 2018 06:03:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 633CD223BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727444AbeHJIcH (ORCPT ); Fri, 10 Aug 2018 04:32:07 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:44493 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725746AbeHJIcH (ORCPT ); Fri, 10 Aug 2018 04:32:07 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fo0WO-0005YV-55; Fri, 10 Aug 2018 08:03:36 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1fo0WM-00054a-Rv; Fri, 10 Aug 2018 08:03:34 +0200 Date: Fri, 10 Aug 2018 08:03:34 +0200 From: Sascha Hauer To: Abel Vesa Cc: Lucas Stach , Dong Aisheng , Pengutronix Kernel Team , Mark Rutland , Rob Herring , devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam , Shawn Guo , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/4] Add i.MX8MQ clock driver Message-ID: <20180810060334.ookq3dm3vylp623o@pengutronix.de> References: <1533825941-17224-1-git-send-email-abel.vesa@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533825941-17224-1-git-send-email-abel.vesa@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:01:54 up 58 days, 15:10, 53 users, load average: 0.08, 0.10, 0.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Abel, On Thu, Aug 09, 2018 at 05:45:37PM +0300, Abel Vesa wrote: > This is basically just a resend of the following patchset: > > https://www.spinics.net/lists/linux-clk/msg23141.html > > I've just updated the patchset and implemented Shawn's > and Aisheng's comments. > > I hope I haven't missed any of their comments. I think what I said to v2 back in march still stays valid: > A general thought: The i.MX8M finally has a consistent clock tree. We > have for example 70 Peripheral clock slices consisting of a mux, a gate > and two dividers, all 70 looking the same. > For these it might make sense to create a more complex clock type > providing mux, gate and set rate functionality in one clock. This would > drastically reduce the number of clocks we have to handle. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |