From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Ravi Chandra Sadineni <ravisadineni@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ravi Chandra Sadineni <ravisadineni@google.com>,
Todd Broch <tbroch@google.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Tomasz Figa <tfiga@chromium.org>
Subject: Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.
Date: Fri, 10 Aug 2018 10:23:43 +0200 [thread overview]
Message-ID: <20180810082344eucas1p2c525a61cb176b4ab1dab22347afd539b~JeE3uTBkU1731217312eucas1p2T@eucas1p2.samsung.com> (raw)
In-Reply-To: <85a59afc-9dc0-b9fb-7e8f-32731337884c@samsung.com>
Hi Ravi,
Just to let you know - I hope I've finally bisected all the issues related
to suspend/resume on Samsung Chromebooks with mainline kernel. I did my
tests on Linux next-20180809. The mentioned commit 38ba34a43dbc ("Input:
cros_ec_keyb - mark cros_ec_keyb driver as wake enabled device.") breaks
suspend/resume operation also on Samsung Exynos5420-based Peach-Pit
Chromebook. Here is some more information how to get suspend/resume
working with mainline on that board:
https://patchwork.kernel.org/patch/10562419/
Best regards
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 2018-08-08 07:03, Marek Szyprowski wrote:
> Hi Ravi,
>
> On 2018-08-07 23:59, Ravi Chandra Sadineni wrote:
>> hi Merek,
>>
>> I tried booting a snow device and could not get it to boot it to the
>> console. I assume i don't have right kernel config. Can you share your
>> config if possible.
>
> I use standard exynos_defconfig bundled with Linux kernel. I've followed
> this instruction to boot in on Snow:
>
> https://s-opensource.org/2016/03/24/use-mainline-u-boot-non-signed-kernels-exynos-chromebooks/
>
>
>>
>> Thanks,
>> RaviOn Mon, Aug 6, 2018 at 4:05 PM Ravi Chandra Sadineni
>> <ravisadineni@chromium.org> wrote:
>>> Hi Merek,
>>>
>>> Thanks for the info. Lemme understand what's going on. Will update the
>>> thread once I have more info.
>>>
>>> Thanks,
>>> Ravi
>>> On Mon, Aug 6, 2018 at 12:15 AM Marek Szyprowski
>>> <m.szyprowski@samsung.com> wrote:
>>>> Hi Dmitry
>>>>
>>>> On 2018-08-06 08:16, Dmitry Torokhov wrote:
>>>>> On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski
>>>>> <m.szyprowski@samsung.com> wrote:
>>>>>> Hi Ravi,
>>>>>>
>>>>>> On 2018-08-03 18:53, Ravi Chandra Sadineni wrote:
>>>>>>> Understood. I am trying to reproduce this issue locally. Wanted to
>>>>>>> know the version of the kernel so I can give a try. Marek, can you
>>>>>>> please confirm the kernel version.
>>>>>>>
>>>>>> Yes, sorry for the missing context, I was in hurry writing the
>>>>>> report and
>>>>>> I wanted to send it before leaving the office. I'm testing
>>>>>> mainline on Snow
>>>>>> with exynos_defconfig.
>>>>>>
>>>>>> Suspend/resume is partially broken already with mainline, but if
>>>>>> you disable
>>>>>> CPUfreq support, it works fine on Linux v4.17.
>>>>>>
>>>>>> I've posted CPUfreq related fixes here if you are interested:
>>>>>> https://patchwork.kernel.org/patch/10554607/
>>>>>> https://patchwork.kernel.org/patch/10554603/
>>>>>>
>>>>>> The issue with cros_ec_keyb patch appears first on Linux
>>>>>> v4.18-rc1, which is
>>>>>> the first release with that patch.
>>>>> Marek, this patch should only be in -next, I do not believe I sent it
>>>>> to Linus just yet. If mainline is broken for you it can't be
>>>>> caused by
>>>>> this patch.
>>>> Aaahh. My fault then. The suspend/resume issue is cause by commit
>>>> 38ba34a43dbc ("Input: cros_ec_keyb - mark cros_ec_keyb driver as wake
>>>> enabled device."), which has been merged to v4.18-rc1.
>>>>
>>>> It looks that I've downloaded wrong patch from the patchwork to
>>>> reply it
>>>> with a a bug report. :( I'm really sorry for the noise in the wrong
>>>> thread.
>>>>
>>>> Ravi: please let me know how can I help you to debug this issue.
>>>>
>>>>>> Linux -next from 20180803, which has a few
>>>>>> more patches for cros_ec_keyb suffers from the same issue.
>>>>> Just to confirm, if you revert only this patch from -next you get
>>>>> suspend/resume back?
>>>>>
>>>>> Thanks.
>>>> Best regards
>>>> --
>>>> Marek Szyprowski, PhD
>>>> Samsung R&D Institute Poland
>>>>
>>
>
> Best regards
next prev parent reply other threads:[~2018-08-10 8:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 22:44 [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event Ravi Chandra Sadineni
2018-06-12 23:32 ` Dmitry Torokhov
[not found] ` <CGME20180803072628eucas1p26abe0cb121b974401759502f8807bb96@eucas1p2.samsung.com>
2018-08-03 7:26 ` Marek Szyprowski
[not found] ` <CAEZbON7qLheHFuU6zwArCz=CG03JvnFjcehBGjE4RqROYrMLhQ@mail.gmail.com>
2018-08-03 16:07 ` Dmitry Torokhov
[not found] ` <CAEZbON4O0X8Fo6eAbmPOSiB1_Tw7x+Ox3ROoGfZQn72uQGQLkg@mail.gmail.com>
2018-08-06 5:29 ` Marek Szyprowski
2018-08-06 6:16 ` Dmitry Torokhov
2018-08-06 7:15 ` Marek Szyprowski
2018-08-06 23:05 ` Ravi Chandra Sadineni
2018-08-07 21:59 ` Ravi Chandra Sadineni
2018-08-08 5:03 ` Marek Szyprowski
[not found] ` <85a59afc-9dc0-b9fb-7e8f-32731337884c@samsung.com>
2018-08-10 8:23 ` Marek Szyprowski [this message]
2018-08-17 21:21 ` RaviChandra Sadineni
2018-08-20 8:52 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20180810082344eucas1p2c525a61cb176b4ab1dab22347afd539b~JeE3uTBkU1731217312eucas1p2T@eucas1p2.samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ravisadineni@chromium.org \
--cc=ravisadineni@google.com \
--cc=tbroch@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).