LKML Archive on lore.kernel.org
 help / Atom feed
* [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
@ 2018-08-08 15:55 Steven Rostedt
  2018-08-08 17:52 ` Steven Rostedt
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Steven Rostedt @ 2018-08-08 15:55 UTC (permalink / raw)
  To: linux-kernel, linux-trace-devel
  Cc: Arnaldo Carvalho de Melo, Ingo Molnar, Andrew Morton,
	Peter Zijlstra, Namhyung Kim, Masami Hiramatsu, Jiri Olsa,
	Alexander Shishkin, Yordan Karadzhov, Tzvetomir Stoyanov

Having libtraceevent turn into a proper library has long been asked for.
I never had time to do it before. Luckily, Tzvetomir was able to spend
the time to start the preparation. The first thing that needs to be done
is to handle namespace collisions. "pevent" was the prefix I chose, but
many people were displeased by it, as it didn't express what the functions
were used for. After discussing with many people at many conferences
I've come up with "tep", which means "Trace Event Parser". Please don't
question this. The bikeshed has been painted and I'm not changing the
color.

This series changes all the function names and data structures from the
"pevent_" prefix to the "tep_" prefix. Note, it does not change the
names of local variables or even parameters. "pevent" variables and
parameters still exist. We can change those later, but for now, I want
all global references to "pevent" to be "tep_" instead.

This is not complete. It is only one of many preparations to make
libtraceevent into a legitimate library. There's other naming conventions
that will be made. But for now, I would like to hear thoughts about
this change before we proceed further.

Instead of doing one big update, Tzvetomir grouped changes together.
I compiled each patch to make sure perf still builds without errors
at each step. I only used my own configuration, thus there may be
cases that perf might fail to build. Here's what I had:

Auto-detecting system features:
...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ OFF ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ OFF ]
...        numa_num_possible_cpus: [ OFF ]
...                       libperl: [ OFF ]
...                     libpython: [ on  ]
...                      libslang: [ OFF ]
...                     libcrypto: [ on  ]
...                     libunwind: [ OFF ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]

The above is the config I used for testing the build.

-- Steve

Tzvetomir Stoyanov (VMware) (24):
      tools/lib/traceevent, tools/perf: Rename struct pevent to struct tep_handle
      tools/lib/traceevent, tools/perf: Rename struct pevent_record to struct tep_record
      tools/lib/traceevent, tools/perf: Rename pevent plugin related APIs
      tools/lib/traceevent, tools/perf: Rename pevent alloc / free APIs
      tools/lib/traceevent, tools/perf: Rename pevent find APIs
      tools/lib/traceevent, tools/perf: Rename pevent parse APIs
      tools/lib/traceevent, tools/perf: Rename pevent print APIs
      tools/lib/traceevent, tools/perf: Rename pevent_read_number_* APIs
      tools/lib/traceevent, tools/perf: Rename pevent_register_* APIs
      tools/lib/traceevent, tools/perf: Rename pevent_set_* APIs
      tools/lib/traceevent, tools/perf: Rename traceevent_* APIs
      tools/lib/traceevent, tools/perf: Rename enum pevent_flag to enum tep_flag
      tools/lib/traceevent, tools/lib/lockdep/: Rename enunm pevent_errno to enum tep_errno
      tools/lib/traceevent: Rename pevent_function* APIs
      tools/lib/traceevent, tools/perf: Rename traceevent_* APIs
      tools/lib/traceevent: Rename pevent_filter* APIs
      tools/lib/traceevent: Rename pevent_register / unregister APIs
      tools/lib/traceevent: Rename pevent_data_ APIs
      tools/lib/traceevent: Rename pevent field APIs
      tools/lib/traceevent: Rename pevent_find_* APIs
      tools/lib/traceevent: Rename various pevent get/set/is APIs
      tools/lib/traceevent: Rename internal parser related APIs
      tools/lib/traceevent: Rename various pevent APIs
      tools/lib/traceevent: Rename static variables and functions in event-parse.c

----
 tools/lib/lockdep/Makefile                         |   4 +-
 tools/lib/traceevent/Makefile                      |   4 +-
 tools/lib/traceevent/event-parse.c                 | 696 ++++++++++-----------
 tools/lib/traceevent/event-parse.h                 | 458 +++++++-------
 tools/lib/traceevent/event-plugin.c                |  70 +--
 tools/lib/traceevent/parse-filter.c                | 288 ++++-----
 tools/lib/traceevent/plugin_cfg80211.c             |  20 +-
 tools/lib/traceevent/plugin_function.c             |  34 +-
 tools/lib/traceevent/plugin_hrtimer.c              |  56 +-
 tools/lib/traceevent/plugin_jbd2.c                 |  36 +-
 tools/lib/traceevent/plugin_kmem.c                 |  66 +-
 tools/lib/traceevent/plugin_kvm.c                  | 154 ++---
 tools/lib/traceevent/plugin_mac80211.c             |  28 +-
 tools/lib/traceevent/plugin_sched_switch.c         |  60 +-
 tools/lib/traceevent/plugin_scsi.c                 |  24 +-
 tools/lib/traceevent/plugin_xen.c                  |  20 +-
 tools/perf/builtin-kmem.c                          |   6 +-
 tools/perf/builtin-report.c                        |   6 +-
 tools/perf/builtin-script.c                        |   6 +-
 tools/perf/util/data-convert-bt.c                  |   6 +-
 tools/perf/util/evsel.c                            |   2 +-
 tools/perf/util/header.c                           |   6 +-
 tools/perf/util/machine.h                          |   2 +-
 tools/perf/util/python.c                           |  10 +-
 .../perf/util/scripting-engines/trace-event-perl.c |   2 +-
 .../util/scripting-engines/trace-event-python.c    |   6 +-
 tools/perf/util/sort.c                             |  16 +-
 tools/perf/util/sort.h                             |   2 +-
 tools/perf/util/trace-event-parse.c                |  34 +-
 tools/perf/util/trace-event-read.c                 |  44 +-
 tools/perf/util/trace-event-scripting.c            |   4 +-
 tools/perf/util/trace-event.c                      |  28 +-
 tools/perf/util/trace-event.h                      |  20 +-
 33 files changed, 1109 insertions(+), 1109 deletions(-)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-08 15:55 [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library Steven Rostedt
@ 2018-08-08 17:52 ` Steven Rostedt
  2018-08-09  8:12 ` Jiri Olsa
  2018-08-10  9:21 ` Jiri Olsa
  2 siblings, 0 replies; 12+ messages in thread
From: Steven Rostedt @ 2018-08-08 17:52 UTC (permalink / raw)
  To: linux-kernel, linux-trace-devel
  Cc: Arnaldo Carvalho de Melo, Ingo Molnar, Andrew Morton,
	Peter Zijlstra, Namhyung Kim, Masami Hiramatsu, Jiri Olsa,
	Alexander Shishkin, Yordan Karadzhov, Tzvetomir Stoyanov


Sorry for the messed up threading. I'm using quilt to send the email,
and it appears that Debian testing pulled in a broken version that
doesn't thread the patches properly. It was fixed over a year ago!

  http://git.savannah.nongnu.org/cgit/quilt.git/commit/?id=360b85e1f6b6d1aff5ada942fcee816e1ad7a13c

But Debian testing still has the broken version (and I just recently
updated to it!). I'll be reporting this to Debian.

I'll send out a v2 that fixes the threading. Sorry about this :-(

-- Steve


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-08 15:55 [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library Steven Rostedt
  2018-08-08 17:52 ` Steven Rostedt
@ 2018-08-09  8:12 ` Jiri Olsa
  2018-08-09 13:40   ` Steven Rostedt
  2018-08-10  9:21 ` Jiri Olsa
  2 siblings, 1 reply; 12+ messages in thread
From: Jiri Olsa @ 2018-08-09  8:12 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: linux-kernel, linux-trace-devel, Arnaldo Carvalho de Melo,
	Ingo Molnar, Andrew Morton, Peter Zijlstra, Namhyung Kim,
	Masami Hiramatsu, Alexander Shishkin, Yordan Karadzhov,
	Tzvetomir Stoyanov

On Wed, Aug 08, 2018 at 11:55:48AM -0400, Steven Rostedt wrote:
> Having libtraceevent turn into a proper library has long been asked for.
> I never had time to do it before. Luckily, Tzvetomir was able to spend
> the time to start the preparation. The first thing that needs to be done
> is to handle namespace collisions. "pevent" was the prefix I chose, but
> many people were displeased by it, as it didn't express what the functions
> were used for. After discussing with many people at many conferences
> I've come up with "tep", which means "Trace Event Parser". Please don't
> question this. The bikeshed has been painted and I'm not changing the
> color.

nah... now when I see it 'te' actualy sounds better ;)))) just kidding,
great we finaly got to this.. is there a branch somewhere with this?

thanks,
jirka

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-09  8:12 ` Jiri Olsa
@ 2018-08-09 13:40   ` Steven Rostedt
  0 siblings, 0 replies; 12+ messages in thread
From: Steven Rostedt @ 2018-08-09 13:40 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: linux-kernel, linux-trace-devel, Arnaldo Carvalho de Melo,
	Ingo Molnar, Andrew Morton, Peter Zijlstra, Namhyung Kim,
	Masami Hiramatsu, Alexander Shishkin, Yordan Karadzhov,
	Tzvetomir Stoyanov

On Thu, 9 Aug 2018 10:12:02 +0200
Jiri Olsa <jolsa@redhat.com> wrote:

> nah... now when I see it 'te' actualy sounds better ;)))) just kidding,
> great we finaly got to this.. is there a branch somewhere with this?

I just pushed it to my repo:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git

  branch: tip/perf/core

Based off of commit ec2cb7a526d49b65576301e183448fb51ee543a6 from tip's
perf/core tree.

-- Steve

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-08 15:55 [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library Steven Rostedt
  2018-08-08 17:52 ` Steven Rostedt
  2018-08-09  8:12 ` Jiri Olsa
@ 2018-08-10  9:21 ` Jiri Olsa
  2018-08-10 13:00   ` Steven Rostedt
  2 siblings, 1 reply; 12+ messages in thread
From: Jiri Olsa @ 2018-08-10  9:21 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: linux-kernel, linux-trace-devel, Arnaldo Carvalho de Melo,
	Ingo Molnar, Andrew Morton, Peter Zijlstra, Namhyung Kim,
	Masami Hiramatsu, Alexander Shishkin, Yordan Karadzhov,
	Tzvetomir Stoyanov

On Wed, Aug 08, 2018 at 11:55:48AM -0400, Steven Rostedt wrote:
> Having libtraceevent turn into a proper library has long been asked for.
> I never had time to do it before. Luckily, Tzvetomir was able to spend
> the time to start the preparation. The first thing that needs to be done
> is to handle namespace collisions. "pevent" was the prefix I chose, but
> many people were displeased by it, as it didn't express what the functions
> were used for. After discussing with many people at many conferences
> I've come up with "tep", which means "Trace Event Parser". Please don't
> question this. The bikeshed has been painted and I'm not changing the
> color.
> 
> This series changes all the function names and data structures from the
> "pevent_" prefix to the "tep_" prefix. Note, it does not change the
> names of local variables or even parameters. "pevent" variables and
> parameters still exist. We can change those later, but for now, I want
> all global references to "pevent" to be "tep_" instead.
> 
> This is not complete. It is only one of many preparations to make
> libtraceevent into a legitimate library. There's other naming conventions
> that will be made. But for now, I would like to hear thoughts about
> this change before we proceed further.

right, I can see more things that needs rename, like in print_arg*,
trace_* stuff and others

I'm also getting weird make error when compiling in libtraceevent dir:

  [jolsa@krava traceevent]$ make
    GEN      libtraceevent-dynamic-list
  Either missing one of [ plugin_jbd2.so plugin_hrtimer.so plugin_kmem.so plugin_kvm.so plugin_mac80211.so plugin_sched_switch.so plugin_function.so plugin_xen.so plugin_scsi.so plugin_cfg80211.so] or bad version of nm

but that seems to be there even without your patchset,
so probably something we should look into

other than that it looks ok to me

once this is done, we can move forward to put this
to kernel-tools-libs-devel rpm

thanks,
jirka

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-10  9:21 ` Jiri Olsa
@ 2018-08-10 13:00   ` Steven Rostedt
  2018-08-10 13:14     ` Jiri Olsa
  0 siblings, 1 reply; 12+ messages in thread
From: Steven Rostedt @ 2018-08-10 13:00 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: linux-kernel, linux-trace-devel, Arnaldo Carvalho de Melo,
	Ingo Molnar, Andrew Morton, Peter Zijlstra, Namhyung Kim,
	Masami Hiramatsu, Alexander Shishkin, Yordan Karadzhov,
	Tzvetomir Stoyanov

On Fri, 10 Aug 2018 11:21:37 +0200
Jiri Olsa <jolsa@redhat.com> wrote:


> > This is not complete. It is only one of many preparations to make
> > libtraceevent into a legitimate library. There's other naming conventions
> > that will be made. But for now, I would like to hear thoughts about
> > this change before we proceed further.  
> 
> right, I can see more things that needs rename, like in print_arg*,
> trace_* stuff and others

We are working on renaming the other data structures. As for the
"trace_" it is really "trace_seq_*" That's not going to get renamed. We
may move it to another header file. It matches the trace_seq_* code in
the kernel, and I would like to keep that the same.

> 
> I'm also getting weird make error when compiling in libtraceevent dir:
> 
>   [jolsa@krava traceevent]$ make
>     GEN      libtraceevent-dynamic-list
>   Either missing one of [ plugin_jbd2.so plugin_hrtimer.so plugin_kmem.so plugin_kvm.so plugin_mac80211.so plugin_sched_switch.so plugin_function.so plugin_xen.so plugin_scsi.so plugin_cfg80211.so] or bad version of nm
> 
> but that seems to be there even without your patchset,
> so probably something we should look into

Hmm, OK, I'll try to look into that later.

> 
> other than that it looks ok to me

Great!

> 
> once this is done, we can move forward to put this
> to kernel-tools-libs-devel rpm

For this patch series, do you want to take the patch set, or just pull
from my branch?

-- Steve

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-10 13:00   ` Steven Rostedt
@ 2018-08-10 13:14     ` Jiri Olsa
  2018-08-10 16:57       ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 12+ messages in thread
From: Jiri Olsa @ 2018-08-10 13:14 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: linux-kernel, linux-trace-devel, Arnaldo Carvalho de Melo,
	Ingo Molnar, Andrew Morton, Peter Zijlstra, Namhyung Kim,
	Masami Hiramatsu, Alexander Shishkin, Yordan Karadzhov,
	Tzvetomir Stoyanov

On Fri, Aug 10, 2018 at 09:00:10AM -0400, Steven Rostedt wrote:
> On Fri, 10 Aug 2018 11:21:37 +0200
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> 
> > > This is not complete. It is only one of many preparations to make
> > > libtraceevent into a legitimate library. There's other naming conventions
> > > that will be made. But for now, I would like to hear thoughts about
> > > this change before we proceed further.  
> > 
> > right, I can see more things that needs rename, like in print_arg*,
> > trace_* stuff and others
> 
> We are working on renaming the other data structures. As for the
> "trace_" it is really "trace_seq_*" That's not going to get renamed. We
> may move it to another header file. It matches the trace_seq_* code in
> the kernel, and I would like to keep that the same.
> 
> > 
> > I'm also getting weird make error when compiling in libtraceevent dir:
> > 
> >   [jolsa@krava traceevent]$ make
> >     GEN      libtraceevent-dynamic-list
> >   Either missing one of [ plugin_jbd2.so plugin_hrtimer.so plugin_kmem.so plugin_kvm.so plugin_mac80211.so plugin_sched_switch.so plugin_function.so plugin_xen.so plugin_scsi.so plugin_cfg80211.so] or bad version of nm
> > 
> > but that seems to be there even without your patchset,
> > so probably something we should look into
> 
> Hmm, OK, I'll try to look into that later.
> 
> > 
> > other than that it looks ok to me
> 
> Great!
> 
> > 
> > once this is done, we can move forward to put this
> > to kernel-tools-libs-devel rpm
> 
> For this patch series, do you want to take the patch set, or just pull
> from my branch?

Arnaldo takes care of that, but I guess pulling from branch is the prefered way

jirka

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-10 13:14     ` Jiri Olsa
@ 2018-08-10 16:57       ` Arnaldo Carvalho de Melo
  2018-08-15  2:54         ` Steven Rostedt
  0 siblings, 1 reply; 12+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-08-10 16:57 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Steven Rostedt, linux-kernel, linux-trace-devel, Ingo Molnar,
	Andrew Morton, Peter Zijlstra, Namhyung Kim, Masami Hiramatsu,
	Alexander Shishkin, Yordan Karadzhov, Tzvetomir Stoyanov

Em Fri, Aug 10, 2018 at 03:14:01PM +0200, Jiri Olsa escreveu:
> On Fri, Aug 10, 2018 at 09:00:10AM -0400, Steven Rostedt wrote:
> > On Fri, 10 Aug 2018 11:21:37 +0200
> > Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > 
> > > > This is not complete. It is only one of many preparations to make
> > > > libtraceevent into a legitimate library. There's other naming conventions
> > > > that will be made. But for now, I would like to hear thoughts about
> > > > this change before we proceed further.  
> > > 
> > > right, I can see more things that needs rename, like in print_arg*,
> > > trace_* stuff and others
> > 
> > We are working on renaming the other data structures. As for the
> > "trace_" it is really "trace_seq_*" That's not going to get renamed. We
> > may move it to another header file. It matches the trace_seq_* code in
> > the kernel, and I would like to keep that the same.
> > 
> > > 
> > > I'm also getting weird make error when compiling in libtraceevent dir:
> > > 
> > >   [jolsa@krava traceevent]$ make
> > >     GEN      libtraceevent-dynamic-list
> > >   Either missing one of [ plugin_jbd2.so plugin_hrtimer.so plugin_kmem.so plugin_kvm.so plugin_mac80211.so plugin_sched_switch.so plugin_function.so plugin_xen.so plugin_scsi.so plugin_cfg80211.so] or bad version of nm
> > > 
> > > but that seems to be there even without your patchset,
> > > so probably something we should look into
> > 
> > Hmm, OK, I'll try to look into that later.
> > 
> > > 
> > > other than that it looks ok to me
> > 
> > Great!
> > 
> > > 
> > > once this is done, we can move forward to put this
> > > to kernel-tools-libs-devel rpm
> > 
> > For this patch series, do you want to take the patch set, or just pull
> > from my branch?
> 
> Arnaldo takes care of that, but I guess pulling from branch is the prefered way

I'll try pulling and building it automatically patch by patch,

- Arnaldo

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-10 16:57       ` Arnaldo Carvalho de Melo
@ 2018-08-15  2:54         ` Steven Rostedt
  2018-08-15  7:04           ` Jiri Olsa
  0 siblings, 1 reply; 12+ messages in thread
From: Steven Rostedt @ 2018-08-15  2:54 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Jiri Olsa, linux-kernel, linux-trace-devel, Ingo Molnar,
	Andrew Morton, Peter Zijlstra, Namhyung Kim, Masami Hiramatsu,
	Alexander Shishkin, Yordan Karadzhov, Tzvetomir Stoyanov

On Fri, 10 Aug 2018 13:57:06 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> > Arnaldo takes care of that, but I guess pulling from branch is the prefered way  
> 
> I'll try pulling and building it automatically patch by patch,

Hi Arnaldo,

Were you able to take this? We have another patch series that's ready
to go (it can wait till after the merge window though).

-- Steve

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-15  2:54         ` Steven Rostedt
@ 2018-08-15  7:04           ` Jiri Olsa
  2018-08-15 13:54             ` Steven Rostedt
  0 siblings, 1 reply; 12+ messages in thread
From: Jiri Olsa @ 2018-08-15  7:04 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Arnaldo Carvalho de Melo, linux-kernel, linux-trace-devel,
	Ingo Molnar, Andrew Morton, Peter Zijlstra, Namhyung Kim,
	Masami Hiramatsu, Alexander Shishkin, Yordan Karadzhov,
	Tzvetomir Stoyanov

On Tue, Aug 14, 2018 at 10:54:35PM -0400, Steven Rostedt wrote:
> On Fri, 10 Aug 2018 13:57:06 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> 
> > > Arnaldo takes care of that, but I guess pulling from branch is the prefered way  
> > 
> > I'll try pulling and building it automatically patch by patch,
> 
> Hi Arnaldo,
> 
> Were you able to take this? We have another patch series that's ready
> to go (it can wait till after the merge window though).

I see all that in Arnaldo's perf/core branch

jirka

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-15  7:04           ` Jiri Olsa
@ 2018-08-15 13:54             ` Steven Rostedt
  2018-08-15 14:51               ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 12+ messages in thread
From: Steven Rostedt @ 2018-08-15 13:54 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Arnaldo Carvalho de Melo, linux-kernel, linux-trace-devel,
	Ingo Molnar, Andrew Morton, Peter Zijlstra, Namhyung Kim,
	Masami Hiramatsu, Alexander Shishkin, Yordan Karadzhov,
	Tzvetomir Stoyanov

On Wed, 15 Aug 2018 09:04:59 +0200
Jiri Olsa <jolsa@redhat.com> wrote:

> On Tue, Aug 14, 2018 at 10:54:35PM -0400, Steven Rostedt wrote:
> > On Fri, 10 Aug 2018 13:57:06 -0300
> > Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >   
> > > > Arnaldo takes care of that, but I guess pulling from branch is the prefered way    
> > > 
> > > I'll try pulling and building it automatically patch by patch,  
> > 
> > Hi Arnaldo,
> > 
> > Were you able to take this? We have another patch series that's ready
> > to go (it can wait till after the merge window though).  
> 
> I see all that in Arnaldo's perf/core branch
> 


OK, cool. I don't have Arnaldo's branch, but was looking for tip pulls.

-- Steve

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
  2018-08-15 13:54             ` Steven Rostedt
@ 2018-08-15 14:51               ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 12+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-08-15 14:51 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Jiri Olsa, linux-kernel, linux-trace-devel, Ingo Molnar,
	Andrew Morton, Peter Zijlstra, Namhyung Kim, Masami Hiramatsu,
	Alexander Shishkin, Yordan Karadzhov, Tzvetomir Stoyanov

Em Wed, Aug 15, 2018 at 09:54:13AM -0400, Steven Rostedt escreveu:
> On Wed, 15 Aug 2018 09:04:59 +0200
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Tue, Aug 14, 2018 at 10:54:35PM -0400, Steven Rostedt wrote:
> > > On Fri, 10 Aug 2018 13:57:06 -0300
> > > Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > >   
> > > > > Arnaldo takes care of that, but I guess pulling from branch is the prefered way    
> > > > 
> > > > I'll try pulling and building it automatically patch by patch,  
> > > 
> > > Hi Arnaldo,
> > > 
> > > Were you able to take this? We have another patch series that's ready
> > > to go (it can wait till after the merge window though).  

> > I see all that in Arnaldo's perf/core branch
> 
> OK, cool. I don't have Arnaldo's branch, but was looking for tip pulls.

Its going to Ingo today, it passed all tests, together with other
patches for this pull req:

Test results:

The first ones are container (docker) based builds of tools/perf with
and without libelf support.  Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.

The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.

Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.

The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.

Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.

  # dm
   1 alpine:3.4                    : Ok   gcc (Alpine 5.3.0) 5.3.0
   2 alpine:3.5                    : Ok   gcc (Alpine 6.2.1) 6.2.1 20160822
   3 alpine:3.6                    : Ok   gcc (Alpine 6.3.0) 6.3.0
   4 alpine:3.7                    : Ok   gcc (Alpine 6.4.0) 6.4.0
   5 alpine:3.8                    : Ok   gcc (Alpine 6.4.0) 6.4.0
   6 alpine:edge                   : Ok   gcc (Alpine 6.4.0) 6.4.0
   7 amazonlinux:1                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
   8 amazonlinux:2                 : Ok   gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
   9 android-ndk:r12b-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
  10 android-ndk:r15c-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
  11 centos:5                      : Ok   gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
  12 centos:6                      : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
  13 centos:7                      : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
  14 debian:7                      : Ok   gcc (Debian 4.7.2-5) 4.7.2
  15 debian:8                      : Ok   gcc (Debian 4.9.2-10+deb8u1) 4.9.2
  16 debian:9                      : Ok   gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
  17 debian:experimental           : Ok   gcc (Debian 8.2.0-1) 8.2.0
  18 debian:experimental-x-arm64   : Ok   aarch64-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
  19 debian:experimental-x-mips    : Ok   mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
  20 debian:experimental-x-mips64  : Ok   mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0
  21 debian:experimental-x-mipsel  : Ok   mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
  22 fedora:20                     : Ok   gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
  23 fedora:21                     : Ok   gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
  24 fedora:22                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  25 fedora:23                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  26 fedora:24                     : Ok   gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
  27 fedora:24-x-ARC-uClibc        : Ok   arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
  28 fedora:25                     : Ok   gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
  29 fedora:26                     : Ok   gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
  30 fedora:27                     : Ok   gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6)
  31 fedora:28                     : Ok   gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
  32 fedora:rawhide                : Ok   gcc (GCC) 8.0.1 20180324 (Red Hat 8.0.1-0.20)
  33 gentoo-stage3-amd64:latest    : Ok   gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0
  34 mageia:5                      : Ok   gcc (GCC) 4.9.2
  35 mageia:6                      : Ok   gcc (Mageia 5.5.0-1.mga6) 5.5.0
  36 opensuse:13.2                 : Ok   gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064]
  37 opensuse:42.1                 : Ok   gcc (SUSE Linux) 4.8.5
  38 opensuse:42.2                 : Ok   gcc (SUSE Linux) 4.8.5
  39 opensuse:42.3                 : Ok   gcc (SUSE Linux) 4.8.5
  40 opensuse:tumbleweed           : Ok   gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812]
  41 oraclelinux:6                 : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
  42 oraclelinux:7                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1)
  43 ubuntu:12.04.5                : Ok   gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
  44 ubuntu:14.04.4                : Ok   gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
  45 ubuntu:14.04.4-x-linaro-arm64 : Ok   aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
  46 ubuntu:16.04                  : Ok   gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
  47 ubuntu:16.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  48 ubuntu:16.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  49 ubuntu:16.04-x-powerpc        : Ok   powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  50 ubuntu:16.04-x-powerpc64      : Ok   powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  51 ubuntu:16.04-x-powerpc64el    : Ok   powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  52 ubuntu:16.04-x-s390           : Ok   s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  53 ubuntu:16.10                  : Ok   gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
  54 ubuntu:17.10                  : Ok   gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
  55 ubuntu:18.04                  : Ok   gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  56 ubuntu:18.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
  57 ubuntu:18.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
  58 ubuntu:18.04-x-m68k           : Ok   m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  59 ubuntu:18.04-x-powerpc        : Ok   powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  60 ubuntu:18.04-x-powerpc64      : Ok   powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  61 ubuntu:18.04-x-powerpc64el    : Ok   powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  62 ubuntu:18.04-x-riscv64        : Ok   riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  63 ubuntu:18.04-x-s390           : Ok   s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  64 ubuntu:18.04-x-sh4            : Ok   sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  65 ubuntu:18.04-x-sparc64        : Ok   sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  66 ubuntu:18.10                  : Ok   gcc (Ubuntu 8.2.0-1ubuntu2) 8.2.0
  # 

  # uname -a
  Linux seventh 4.18.0-rc8-00002-g1236568ee3cb #1 SMP Wed Aug 8 09:39:17 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
  # git log --oneline -1
  6855dc41b246 (HEAD -> perf/core) x86: Add entry trampolines to kcore
  # perf version --build-options
  perf version 4.18.rc7.g6855dc
                   dwarf: [ on  ]  # HAVE_DWARF_SUPPORT
      dwarf_getlocations: [ on  ]  # HAVE_DWARF_GETLOCATIONS_SUPPORT
                   glibc: [ on  ]  # HAVE_GLIBC_SUPPORT
                    gtk2: [ on  ]  # HAVE_GTK2_SUPPORT
           syscall_table: [ on  ]  # HAVE_SYSCALL_TABLE_SUPPORT
                  libbfd: [ on  ]  # HAVE_LIBBFD_SUPPORT
                  libelf: [ on  ]  # HAVE_LIBELF_SUPPORT
                 libnuma: [ on  ]  # HAVE_LIBNUMA_SUPPORT
  numa_num_possible_cpus: [ on  ]  # HAVE_LIBNUMA_SUPPORT
                 libperl: [ on  ]  # HAVE_LIBPERL_SUPPORT
               libpython: [ on  ]  # HAVE_LIBPYTHON_SUPPORT
                libslang: [ on  ]  # HAVE_SLANG_SUPPORT
               libcrypto: [ on  ]  # HAVE_LIBCRYPTO_SUPPORT
               libunwind: [ on  ]  # HAVE_LIBUNWIND_SUPPORT
      libdw-dwarf-unwind: [ on  ]  # HAVE_DWARF_SUPPORT
                    zlib: [ on  ]  # HAVE_ZLIB_SUPPORT
                    lzma: [ on  ]  # HAVE_LZMA_SUPPORT
               get_cpuid: [ on  ]  # HAVE_AUXTRACE_SUPPORT
                     bpf: [ on  ]  # HAVE_LIBBPF_SUPPORT
  # perf test
   1: vmlinux symtab matches kallsyms                       : Ok
   2: Detect openat syscall event                           : Ok
   3: Detect openat syscall event on all cpus               : Ok
   4: Read samples using the mmap interface                 : Ok
   5: Test data source output                               : Ok
   6: Parse event definition strings                        : Ok
   7: Simple expression parser                              : Ok
   8: PERF_RECORD_* events & perf_sample fields             : Ok
   9: Parse perf pmu format                                 : Ok
  10: DSO data read                                         : Ok
  11: DSO data cache                                        : Ok
  12: DSO data reopen                                       : Ok
  13: Roundtrip evsel->name                                 : Ok
  14: Parse sched tracepoints fields                        : Ok
  15: syscalls:sys_enter_openat event fields                : Ok
  16: Setup struct perf_event_attr                          : Ok
  17: Match and link multiple hists                         : Ok
  18: 'import perf' in python                               : Ok
  19: Breakpoint overflow signal handler                    : Ok
  20: Breakpoint overflow sampling                          : Ok
  21: Breakpoint accounting                                 : Ok
  22: Number of exit events of a simple workload            : Ok
  23: Software clock events period values                   : Ok
  24: Object code reading                                   : Ok
  25: Sample parsing                                        : Ok
  26: Use a dummy software event to keep tracking           : Ok
  27: Parse with no sample_id_all bit set                   : Ok
  28: Filter hist entries                                   : Ok
  29: Lookup mmap thread                                    : Ok
  30: Share thread mg                                       : Ok
  31: Sort output of hist entries                           : Ok
  32: Cumulate child hist entries                           : Ok
  33: Track with sched_switch                               : Ok
  34: Filter fds with revents mask in a fdarray             : Ok
  35: Add fd to a fdarray, making it autogrow               : Ok
  36: kmod_path__parse                                      : Ok
  37: Thread map                                            : Ok
  38: LLVM search and compile                               :
  38.1: Basic BPF llvm compile                              : Ok
  38.2: kbuild searching                                    : Ok
  38.3: Compile source for BPF prologue generation          : Ok
  38.4: Compile source for BPF relocation                   : Ok
  39: Session topology                                      : Ok
  40: BPF filter                                            :
  40.1: Basic BPF filtering                                 : Ok
  40.2: BPF pinning                                         : Ok
  40.3: BPF prologue generation                             : Ok
  40.4: BPF relocation checker                              : Ok
  41: Synthesize thread map                                 : Ok
  42: Remove thread map                                     : Ok
  43: Synthesize cpu map                                    : Ok
  44: Synthesize stat config                                : Ok
  45: Synthesize stat                                       : Ok
  46: Synthesize stat round                                 : Ok
  47: Synthesize attr update                                : Ok
  48: Event times                                           : Ok
  49: Read backward ring buffer                             : Ok
  50: Print cpu map                                         : Ok
  51: Probe SDT events                                      : Ok
  52: is_printable_array                                    : Ok
  53: Print bitmap                                          : Ok
  54: perf hooks                                            : Ok
  55: builtin clang support                                 : Skip (not compiled in)
  56: unit_number__scnprintf                                : Ok
  57: mem2node                                              : Ok
  58: x86 rdpmc                                             : Ok
  59: Convert perf time to TSC                              : Ok
  60: DWARF unwind                                          : Ok
  61: x86 instruction decoder - new instructions            : Ok
  62: probe libc's inet_pton & backtrace it with ping       : Ok
  63: Check open filename arg using perf trace + vfs_getname: Ok
  64: Use vfs_getname probe to get syscall args filenames   : Ok
  65: Add vfs_getname probe to get syscall args filenames   : Ok
  # 
  
  $ make -C tools/perf build-test
  make: Entering directory '/home/acme/git/perf/tools/perf'
  - tarpkg: ./tests/perf-targz-src-pkg .
            make_no_libaudit_O: make NO_LIBAUDIT=1
                   make_tags_O: make tags
                make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
              make_no_libelf_O: make NO_LIBELF=1
              make_no_libbpf_O: make NO_LIBBPF=1
             make_util_map_o_O: make util/map.o
                    make_doc_O: make doc
   make_install_prefix_slash_O: make install prefix=/tmp/krava/
  make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
            make_no_demangle_O: make NO_DEMANGLE=1
                 make_static_O: make LDFLAGS=-static
                make_install_O: make install
         make_with_clangllvm_O: make LIBCLANGLLVM=1
            make_install_bin_O: make install-bin
           make_no_libunwind_O: make NO_LIBUNWIND=1
                  make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
               make_no_slang_O: make NO_SLANG=1
           make_no_libpython_O: make NO_LIBPYTHON=1
                make_no_gtk2_O: make NO_GTK2=1
           make_no_libbionic_O: make NO_LIBBIONIC=1
         make_install_prefix_O: make install prefix=/tmp/krava
                  make_debug_O: make DEBUG=1
             make_no_libperl_O: make NO_LIBPERL=1
                   make_pure_O: make
             make_no_libnuma_O: make NO_LIBNUMA=1
       make_util_pmu_bison_o_O: make util/pmu-bison.o
                   make_help_O: make help
                make_no_newt_O: make NO_NEWT=1
           make_no_backtrace_O: make NO_BACKTRACE=1
              make_clean_all_O: make clean all
            make_no_auxtrace_O: make NO_AUXTRACE=1
             make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
                 make_perf_o_O: make perf.o
        make_with_babeltrace_O: make LIBBABELTRACE=1
  OK
  make: Leaving directory '/home/acme/git/perf/tools/perf'
  $ 


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, back to index

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-08 15:55 [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library Steven Rostedt
2018-08-08 17:52 ` Steven Rostedt
2018-08-09  8:12 ` Jiri Olsa
2018-08-09 13:40   ` Steven Rostedt
2018-08-10  9:21 ` Jiri Olsa
2018-08-10 13:00   ` Steven Rostedt
2018-08-10 13:14     ` Jiri Olsa
2018-08-10 16:57       ` Arnaldo Carvalho de Melo
2018-08-15  2:54         ` Steven Rostedt
2018-08-15  7:04           ` Jiri Olsa
2018-08-15 13:54             ` Steven Rostedt
2018-08-15 14:51               ` Arnaldo Carvalho de Melo

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox