From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31885C4646D for ; Fri, 10 Aug 2018 13:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEA0821DEC for ; Fri, 10 Aug 2018 13:14:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEA0821DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728252AbeHJPn5 (ORCPT ); Fri, 10 Aug 2018 11:43:57 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54706 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727534AbeHJPn5 (ORCPT ); Fri, 10 Aug 2018 11:43:57 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1D5081663CE; Fri, 10 Aug 2018 13:14:04 +0000 (UTC) Received: from krava (unknown [10.43.17.133]) by smtp.corp.redhat.com (Postfix) with SMTP id 759B710CD7E4; Fri, 10 Aug 2018 13:14:02 +0000 (UTC) Date: Fri, 10 Aug 2018 15:14:01 +0200 From: Jiri Olsa To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Arnaldo Carvalho de Melo , Ingo Molnar , Andrew Morton , Peter Zijlstra , Namhyung Kim , Masami Hiramatsu , Alexander Shishkin , Yordan Karadzhov , Tzvetomir Stoyanov Subject: Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library Message-ID: <20180810131401.GB4162@krava> References: <20180808155548.510187543@goodmis.org> <20180810092137.GB14485@krava> <20180810090010.4537e14a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180810090010.4537e14a@gandalf.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 10 Aug 2018 13:14:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 10 Aug 2018 13:14:04 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jolsa@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 10, 2018 at 09:00:10AM -0400, Steven Rostedt wrote: > On Fri, 10 Aug 2018 11:21:37 +0200 > Jiri Olsa wrote: > > > > > This is not complete. It is only one of many preparations to make > > > libtraceevent into a legitimate library. There's other naming conventions > > > that will be made. But for now, I would like to hear thoughts about > > > this change before we proceed further. > > > > right, I can see more things that needs rename, like in print_arg*, > > trace_* stuff and others > > We are working on renaming the other data structures. As for the > "trace_" it is really "trace_seq_*" That's not going to get renamed. We > may move it to another header file. It matches the trace_seq_* code in > the kernel, and I would like to keep that the same. > > > > > I'm also getting weird make error when compiling in libtraceevent dir: > > > > [jolsa@krava traceevent]$ make > > GEN libtraceevent-dynamic-list > > Either missing one of [ plugin_jbd2.so plugin_hrtimer.so plugin_kmem.so plugin_kvm.so plugin_mac80211.so plugin_sched_switch.so plugin_function.so plugin_xen.so plugin_scsi.so plugin_cfg80211.so] or bad version of nm > > > > but that seems to be there even without your patchset, > > so probably something we should look into > > Hmm, OK, I'll try to look into that later. > > > > > other than that it looks ok to me > > Great! > > > > > once this is done, we can move forward to put this > > to kernel-tools-libs-devel rpm > > For this patch series, do you want to take the patch set, or just pull > from my branch? Arnaldo takes care of that, but I guess pulling from branch is the prefered way jirka