LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Benno Evers <bevers@mesosphere.com>,
	Krister Johansen <kjlx@templeofstupid.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH] perf tools: Check for null when copying nsinfo.
Date: Fri, 10 Aug 2018 10:18:47 -0300
Message-ID: <20180810131847.GG5395@kernel.org> (raw)
In-Reply-To: <20180810045537.GA479@sejong>

Em Fri, Aug 10, 2018 at 01:55:37PM +0900, Namhyung Kim escreveu:
> Hello,
> 
> On Thu, Aug 09, 2018 at 11:53:48PM +0200, Benno Evers wrote:
> > The argument to nsinfo__copy() was assumed to be valid, but some code paths
> > exist that will lead to NULL being passed.
> > 
> > In particular, running 'perf script -D' on a perf.data file containing an
> > PERF_RECORD_MMAP event associating the '[vdso]' dso with pid 0 earlier in
> > the event stream will lead to a segfault.
> > 
> > Since all calling code is already checking for a non-null return value,
> > just return NULL for this case as well.
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> 
> It seems you missed the Signed-off-by though.

Yeah, please collect Namhyung's Acked-by and provide yours, i.e. your
patch should end with the following lines:


Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Benno Evers <bevers@mesosphere.com>

My git-am scripts will collect the Cc from the e-mail message and add
the Link:  with the Message-id.

Thanks,

- Arnaldo
 
> Thanks,
> Namhyung
> 
> 
> > ---
> >  tools/perf/util/namespaces.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tools/perf/util/namespaces.c b/tools/perf/util/namespaces.c
> > index 5be021701f34..cf8bd123cf73 100644
> > --- a/tools/perf/util/namespaces.c
> > +++ b/tools/perf/util/namespaces.c
> > @@ -139,6 +139,9 @@ struct nsinfo *nsinfo__copy(struct nsinfo *nsi)
> >  {
> >  	struct nsinfo *nnsi;
> >  
> > +	if (nsi == NULL)
> > +		return NULL;
> > +
> >  	nnsi = calloc(1, sizeof(*nnsi));
> >  	if (nnsi != NULL) {
> >  		nnsi->pid = nsi->pid;
> > -- 
> > 2.17.1
> > 

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 21:53 Benno Evers
2018-08-10  4:55 ` Namhyung Kim
2018-08-10 13:18   ` Arnaldo Carvalho de Melo [this message]
2018-08-10 13:38     ` Benno Evers

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180810131847.GG5395@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bevers@mesosphere.com \
    --cc=jolsa@redhat.com \
    --cc=kernel-team@lge.com \
    --cc=kjlx@templeofstupid.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox