Hi Matthew, After merging the ida tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/target/iscsi/iscsi_target_login.c: In function 'iscsi_login_zero_tsih_s1': drivers/target/iscsi/iscsi_target_login.c:376:16: error: 'sess_idr_lock' undeclared (first use in this function); did you mean 'auth_id_lock'? spin_lock_bh(&sess_idr_lock); ^~~~~~~~~~~~~ auth_id_lock drivers/target/iscsi/iscsi_target_login.c:376:16: note: each undeclared identifier is reported only once for each function it appears in drivers/target/iscsi/iscsi_target_login.c:377:14: error: 'sess_idr' undeclared (first use in this function); did you mean 'sess_ida'? idr_remove(&sess_idr, sess->session_index); ^~~~~~~~ sess_ida Caused by commit 9cd88edeaa9d ("target/iscsi: Allocate session IDs from an IDA") interacting with commit ad86353cbddb ("iscsi target: fix session creation failure handling") I have reverted commit 9cd88edeaa9d for today. -- Cheers, Stephen Rothwell