From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77722C46464 for ; Fri, 10 Aug 2018 16:57:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E4D822432 for ; Fri, 10 Aug 2018 16:57:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jSlWRTvr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E4D822432 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729764AbeHJT1t (ORCPT ); Fri, 10 Aug 2018 15:27:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:57358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbeHJT1t (ORCPT ); Fri, 10 Aug 2018 15:27:49 -0400 Received: from jouet.infradead.org (unknown [190.15.121.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 625812242B; Fri, 10 Aug 2018 16:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1533920229; bh=tDZFF723kTzNHWCBODMX9sfRfjeSu3DS7DRSKrKdhT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jSlWRTvrC6WNbXJpZfcTmZ1ynBSc0JMku3kvQSRZGsbNzumb2vOM9gBHdA3qzGJVG vNuYdV0znCI8N/ahhVqLxW6Gt6TOSH5VyTpxKO9iBc58NEkOMsBQBOIMHJCKjCYkNV vRlrkFLvecDGR2wsjPIjhlFvVZdhVgKbyjGhnNlk= Received: by jouet.infradead.org (Postfix, from userid 1000) id C53EC140A1C; Fri, 10 Aug 2018 13:57:06 -0300 (-03) Date: Fri, 10 Aug 2018 13:57:06 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Steven Rostedt , linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Ingo Molnar , Andrew Morton , Peter Zijlstra , Namhyung Kim , Masami Hiramatsu , Alexander Shishkin , Yordan Karadzhov , Tzvetomir Stoyanov Subject: Re: [RFC][PATCH 00/24] tools lib traceevent: Rename pevent to tep for preparation for library Message-ID: <20180810165706.GH5395@kernel.org> References: <20180808155548.510187543@goodmis.org> <20180810092137.GB14485@krava> <20180810090010.4537e14a@gandalf.local.home> <20180810131401.GB4162@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180810131401.GB4162@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Aug 10, 2018 at 03:14:01PM +0200, Jiri Olsa escreveu: > On Fri, Aug 10, 2018 at 09:00:10AM -0400, Steven Rostedt wrote: > > On Fri, 10 Aug 2018 11:21:37 +0200 > > Jiri Olsa wrote: > > > > > > > > This is not complete. It is only one of many preparations to make > > > > libtraceevent into a legitimate library. There's other naming conventions > > > > that will be made. But for now, I would like to hear thoughts about > > > > this change before we proceed further. > > > > > > right, I can see more things that needs rename, like in print_arg*, > > > trace_* stuff and others > > > > We are working on renaming the other data structures. As for the > > "trace_" it is really "trace_seq_*" That's not going to get renamed. We > > may move it to another header file. It matches the trace_seq_* code in > > the kernel, and I would like to keep that the same. > > > > > > > > I'm also getting weird make error when compiling in libtraceevent dir: > > > > > > [jolsa@krava traceevent]$ make > > > GEN libtraceevent-dynamic-list > > > Either missing one of [ plugin_jbd2.so plugin_hrtimer.so plugin_kmem.so plugin_kvm.so plugin_mac80211.so plugin_sched_switch.so plugin_function.so plugin_xen.so plugin_scsi.so plugin_cfg80211.so] or bad version of nm > > > > > > but that seems to be there even without your patchset, > > > so probably something we should look into > > > > Hmm, OK, I'll try to look into that later. > > > > > > > > other than that it looks ok to me > > > > Great! > > > > > > > > once this is done, we can move forward to put this > > > to kernel-tools-libs-devel rpm > > > > For this patch series, do you want to take the patch set, or just pull > > from my branch? > > Arnaldo takes care of that, but I guess pulling from branch is the prefered way I'll try pulling and building it automatically patch by patch, - Arnaldo