From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF522C4646D for ; Fri, 10 Aug 2018 17:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83DA12244C for ; Fri, 10 Aug 2018 17:07:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83DA12244C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728624AbeHJTh4 (ORCPT ); Fri, 10 Aug 2018 15:37:56 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49596 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727381AbeHJThz (ORCPT ); Fri, 10 Aug 2018 15:37:55 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7AH3t0H095109 for ; Fri, 10 Aug 2018 13:07:13 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ksd4akm03-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 10 Aug 2018 13:07:12 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Aug 2018 13:07:11 -0400 Received: from b01cxnp22033.gho.pok.ibm.com (9.57.198.23) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 10 Aug 2018 13:07:09 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7AH78PN3473892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Aug 2018 17:07:08 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE843B2068; Fri, 10 Aug 2018 13:06:29 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D12B5B205F; Fri, 10 Aug 2018 13:06:29 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 10 Aug 2018 13:06:29 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 10F4716C3991; Fri, 10 Aug 2018 10:07:09 -0700 (PDT) Date: Fri, 10 Aug 2018 10:07:09 -0700 From: "Paul E. McKenney" To: Steven Rostedt Cc: LKML , Joel Fernandes , Mathieu Desnoyers , Peter Zijlstra Subject: Re: [RFC][PATCH] tracepoints: Free early tracepoints after RCU is initialized Reply-To: paulmck@linux.vnet.ibm.com References: <20180810123042.51ceddb9@gandalf.local.home> <20180810123517.5e9714ad@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180810123517.5e9714ad@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18081017-0072-0000-0000-0000038ECCD8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009519; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01071717; UDB=6.00551962; IPR=6.00851509; MB=3.00022638; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-10 17:07:11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18081017-0073-0000-0000-000049088411 Message-Id: <20180810170709.GW24813@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-10_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=861 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808100183 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 10, 2018 at 12:35:17PM -0400, Steven Rostedt wrote: > On Fri, 10 Aug 2018 12:30:42 -0400 > Steven Rostedt wrote: > > Maybe I should say SRCU? That would be an improvement. What, me read comments? ;-) Thanx, Paul > +/* SRCU is initialized at core_initcall */ > +postcore_initcall(release_early_probes); > + > static inline void release_probes(struct tracepoint_func *old) > { > if (old) { > struct tp_probes *tp_probes = container_of(old, > struct tp_probes, probes[0]); > + > + /* > + * We can't free probes if SRCU is not initialized yet. > + * Postpone the freeing till after SRCU is initialized. > + */ > + if (unlikely(!ok_to_free_tracepoints)) { > + tp_probes->rcu.next = early_probes; > + early_probes = &tp_probes->rcu; > + return; > + } > + > > -- Steve >